Issue 2310 - Handle alternative syntax of Git SSH URLs

ensure_dependencies.py

Index: ensure_dependencies.py
diff --git a/ensure_dependencies.py b/ensure_dependencies.py
index d8af9e718b27d802acd7cde70301341220c6f7eb..ddea6e1ad765edb0ea1acab953a03b8e3e83fd33 100755
--- a/ensure_dependencies.py
+++ b/ensure_dependencies.py
@@ -190,7 +190,12 @@ def ensure_repo(parentrepo, target, roots, sourcename):
   if os.path.exists(roots[type]):
     url = os.path.join(roots[type], sourcename)
   else:
-    url = urlparse.urljoin(roots[type], sourcename)
+    if (type == "git" and "@" in sourcename and
+        not urlparse.urlsplit(sourcename).scheme):
+      # Handle alternative syntax of Git SSH URLS
+      url = "ssh://" + sourcename.replace(":", "/", 1)
+    else:

[Wladimir Palant, 2015/04/29 18:03:05]

This seems to be the wrong place to do it. What we really need to do is
post-process Git "URLs" - all of them. So I'd expect something like:

  root = postprocess_url(roots[type], type)
  sourcename = postprocess_url(sourcename, type)

And the logic joining URLs should be unchanged, merely with roots[type] replaced
by root.

+      url = urlparse.urljoin(roots[type], sourcename)
 
   logging.info("Cloning repository %s into %s" % (url, target))
   repo_types[type].clone(url, target)