Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4553357519749120: Issue 1977 - Consider content location instead element attributes when detecting anonymous frames (Closed)

Created:
Feb. 9, 2015, 2:56 p.m. by Sebastian Noack
Modified:
Feb. 10, 2015, 6:41 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1977 - Consider content location instead element attributes when detecting anonymous frames

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M include.preload.js View 1 chunk +12 lines, -15 lines 2 comments Download

Messages

Total messages: 5
Sebastian Noack
Feb. 9, 2015, 2:57 p.m. (2015-02-09 14:57:00 UTC) #1
kzar
http://codereview.adblockplus.org/4553357519749120/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/4553357519749120/diff/5629499534213120/include.preload.js#newcode94 include.preload.js:94: return contentDocument.location.protocol == "about:"; Previously we would return true ...
Feb. 9, 2015, 4:52 p.m. (2015-02-09 16:52:11 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4553357519749120/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/4553357519749120/diff/5629499534213120/include.preload.js#newcode94 include.preload.js:94: return contentDocument.location.protocol == "about:"; On 2015/02/09 16:52:11, kzar wrote: ...
Feb. 9, 2015, 5:10 p.m. (2015-02-09 17:10:00 UTC) #3
kzar
LGTM
Feb. 9, 2015, 5:11 p.m. (2015-02-09 17:11:55 UTC) #4
Wladimir Palant
Feb. 10, 2015, 6:41 p.m. (2015-02-10 18:41:46 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld