Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 4578973954605056: Fixed: Accel is always mapped to Control, no matter what the actual browser setting is (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by Wladimir Palant
Modified:
6 years, 1 month ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Fixed: Accel is always mapped to Control, no matter what the actual browser setting is

Patch Set 1 #

Patch Set 2 : Turns out, the initial patch reverted https://hg.adblockplus.org/buildtools/rev/26e006a86708 which … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/keySelector.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
6 years, 1 month ago (2014-01-10 16:00:00 UTC) #1
Wladimir Palant
Turns out, the initial patch reverted https://hg.adblockplus.org/buildtools/rev/26e006a86708 which is where this bug has been introduced. ...
6 years, 1 month ago (2014-01-10 16:06:07 UTC) #2
Thomas Greiner
6 years, 1 month ago (2014-01-10 16:19:42 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5