sitescripts/filterhits/schema.sql - Issue 4615801646612480: Issue 395 - Filter hits statistics backend

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/filterhits/schema.sql

Issue 4615801646612480: Issue 395 - Filter hits statistics backend (Closed)

Patch Set: Created Dec. 19, 2014, 1:16 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« sitescripts/filterhits/geometrical_mean.py ('K') | « sitescripts/filterhits/geometrical_mean.py ('k') | sitescripts/filterhits/static/datatables/jquery.js » ('j') | sitescripts/filterhits/static/query.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /!40101 SET @saved_cs_client = @@character_set_client /;

	2 /!40101 SET character_set_client = utf8 /;

	3 CREATE TABLE `filters` (

	4 `md5` BINARY(16) NOT NULL,

	5 `filter` TEXT CHARACTER SET utf8 NOT NULL,

	6 PRIMARY KEY(md5)

	7 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;

	8 /!40101 SET character_set_client = @saved_cs_client /;

	9

	10 /!40101 SET @saved_cs_client = @@character_set_client /;

	11 /!40101 SET character_set_client = utf8 /;
	Sebastian Noack 2015/02/11 16:00:12 This is redundant with the above. Not that we have This is redundant with the above. Not that we have to bother about setting the client charset if we don't INSERT/UPDATE any text data. kzar 2015/02/17 10:52:24 Done. Show quoted text On 2015/02/11 16:00:12, Sebastian Noack wrote: > This is redundant with the above. Not that we have to bother about setting the > client charset if we don't INSERT/UPDATE any text data. Done. Sebastian Noack 2015/02/17 14:59:17 I just realized a typo in my comment above. I actu Show quoted text On 2015/02/17 10:52:24, kzar wrote: > On 2015/02/11 16:00:12, Sebastian Noack wrote: > > This is redundant with the above. Not that we have to bother about setting the > > client charset if we don't INSERT/UPDATE any text data. > > Done. I just realized a typo in my comment above. I actually meant that as long as we don't store any string data here, we don't have to bother about the client charset. However, setting it won't hurt either way. And we're safe in case things change in the future. But thanks for removing the code duplication.
	12 CREATE TABLE `geometrical_mean` (

	13 `filter_md5` BINARY(16) NOT NULL,

	14 `domain` varchar(255) CHARACTER SET utf8 NOT NULL,

	15 `hits` int(10) unsigned DEFAULT 0 NOT NULL,

	16 `timestamp` timestamp NOT NULL,

	17 PRIMARY KEY(domain, filter_md5)

	18 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;

	19 /!40101 SET character_set_client = @saved_cs_client /;

OLD	NEW