Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: sitescripts/filterhits/__init__.py
Issue
4615801646612480
:
Issue 395 - Filter hits statistics backend (Closed)
Left Patch Set: Rebased.
Created March 2, 2015, 8:41 p.m.
Right Patch Set: Addressed further comments from Sebastian.
Created April 2, 2015, 10:13 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Improvements regarding comments
Patch Set 3: Addressed comments.
Patch Set 4: Added API tests, addressed comments and some other improvements.
Patch Set 5: Addressed more comments.
Patch Set 6: Display friendly message if processing script can't connect to DB.
Patch Set 7: Rebased.
Patch Set 8: Simplified geometrical_mean code and reduced filter inserts.
Patch Set 9: Addressed some of Wladimir's comments
Patch Set 10: Addressed Sebastian's and Wladimir's comments.
Patch Set 11: Addressed further comments from Wladimir.
Patch Set 12: Addressed final nits.
Patch Set 13: Rebased.
Patch Set 14: Removed db.testing flag, instead overwrite config during testing.
Patch Set 15: Make test log directory path configurable and ensure it's always cleared.
Patch Set 16: Create temporary log directory with tempfile module for tests.
Patch Set 17: Make sure the temporary log directory is recreated for each test.
Patch Set 18: Addressed further feedback from Sebastian.
Patch Set 19: Created base class for tests and reverted earlier content-type change.
Patch Set 20: Addressed further comments from Sebastian.
Right:
Patch Set 1: None
Patch Set 2: Improvements regarding comments
Patch Set 3: Addressed comments.
Patch Set 4: Added API tests, addressed comments and some other improvements.
Patch Set 5: Addressed more comments.
Patch Set 6: Display friendly message if processing script can't connect to DB.
Patch Set 7: Rebased.
Patch Set 8: Simplified geometrical_mean code and reduced filter inserts.
Patch Set 9: Addressed some of Wladimir's comments
Patch Set 10: Addressed Sebastian's and Wladimir's comments.
Patch Set 11: Addressed further comments from Wladimir.
Patch Set 12: Addressed final nits.
Patch Set 13: Rebased.
Patch Set 14: Removed db.testing flag, instead overwrite config during testing.
Patch Set 15: Make test log directory path configurable and ensure it's always cleared.
Patch Set 16: Create temporary log directory with tempfile module for tests.
Patch Set 17: Make sure the temporary log directory is recreated for each test.
Patch Set 18: Addressed further feedback from Sebastian.
Patch Set 19: Created base class for tests and reverted earlier content-type change.
Patch Set 20: Addressed further comments from Sebastian.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.sitescripts.example
sitescripts/filterhits/__init__.py
sitescripts/filterhits/bin/__init__.py
sitescripts/filterhits/bin/reprocess_logs.py
sitescripts/filterhits/db.py
sitescripts/filterhits/geometrical_mean.py
sitescripts/filterhits/schema.sql
sitescripts/filterhits/static/datatables/jquery.js
sitescripts/filterhits/static/datatables/jquery.dataTables.min.css
sitescripts/filterhits/static/datatables/jquery.dataTables.min.js
sitescripts/filterhits/static/datatables/sort_asc.png
sitescripts/filterhits/static/datatables/sort_both.png
sitescripts/filterhits/static/datatables/sort_desc.png
sitescripts/filterhits/static/query.html
sitescripts/filterhits/static/query.js
sitescripts/filterhits/test/__init__.py
sitescripts/filterhits/test/api_tests.py
sitescripts/filterhits/test/db_tests.py
sitescripts/filterhits/test/geometrical_mean_tests.py
sitescripts/filterhits/test/log_tests.py
sitescripts/filterhits/test/test_helpers.py
sitescripts/filterhits/web/__init__.py
sitescripts/filterhits/web/common.py
sitescripts/filterhits/web/query.py
sitescripts/filterhits/web/submit.py
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« .sitescripts.example
('k') |
sitescripts/filterhits/bin/__init__.py »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
LEFT
RIGHT
« .sitescripts.example
('k') |
sitescripts/filterhits/bin/__init__.py »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 4615801646612480: Issue 395 - Filter hits statistics backend (Closed)
Created Dec. 19, 2014, 1:16 p.m. by kzar
Modified April 3, 2015, 9:48 a.m.
Reviewers: Sebastian Noack, Wladimir Palant
Base URL:
Comments: 246
This is Rietveld