Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4628980216889344: Issue #1234 - Add unit tests for TrimString (Closed)

Created:
Jan. 5, 2015, 3:02 p.m. by Eric
Modified:
Feb. 2, 2015, 1:07 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1234 - Add unit tests for TrimString Add unit tests for TrimString(). This function already existed in the code, but also replaces CString member function Trim().

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M adblockplus.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A test/UtilTest.cpp View 1 2 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Eric
This change is really in anticipation of adding the other replacements for CString member functions.
Jan. 5, 2015, 3:05 p.m. (2015-01-05 15:05:08 UTC) #1
sergei
http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp File test/UtilTest.cpp (right): http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp#newcode22 test/UtilTest.cpp:22: //---------------------------------- I would say we don't need these comments ...
Jan. 5, 2015, 3:27 p.m. (2015-01-05 15:27:43 UTC) #2
Eric
http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp File test/UtilTest.cpp (right): http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp#newcode22 test/UtilTest.cpp:22: //---------------------------------- On 2015/01/05 15:27:43, sergei wrote: > I would ...
Jan. 5, 2015, 4:25 p.m. (2015-01-05 16:25:06 UTC) #3
sergei
http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp File test/UtilTest.cpp (right): http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp#newcode22 test/UtilTest.cpp:22: //---------------------------------- On 2015/01/05 16:25:07, Eric wrote: > On 2015/01/05 ...
Jan. 5, 2015, 4:51 p.m. (2015-01-05 16:51:03 UTC) #4
Eric
http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp File test/UtilTest.cpp (right): http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp#newcode22 test/UtilTest.cpp:22: //---------------------------------- On 2015/01/05 16:51:03, sergei wrote: > Why will ...
Jan. 5, 2015, 5:18 p.m. (2015-01-05 17:18:25 UTC) #5
sergei
http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp File test/UtilTest.cpp (right): http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp#newcode22 test/UtilTest.cpp:22: //---------------------------------- On 2015/01/05 17:18:25, Eric wrote: > On 2015/01/05 ...
Jan. 5, 2015, 9:13 p.m. (2015-01-05 21:13:53 UTC) #6
Oleksandr
http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp File test/UtilTest.cpp (right): http://codereview.adblockplus.org/4628980216889344/diff/5629499534213120/test/UtilTest.cpp#newcode22 test/UtilTest.cpp:22: //---------------------------------- On 2015/01/05 21:13:53, sergei wrote: > On 2015/01/05 ...
Jan. 9, 2015, 12:16 a.m. (2015-01-09 00:16:59 UTC) #7
Eric
New patch set
Jan. 14, 2015, 1:47 p.m. (2015-01-14 13:47:16 UTC) #8
Oleksandr
LGTM
Jan. 30, 2015, 2:25 p.m. (2015-01-30 14:25:42 UTC) #9
sergei
Jan. 30, 2015, 2:28 p.m. (2015-01-30 14:28:46 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld