Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(450)

Issue 4635035198029824: Issue 1390 - Record referrer for download stats (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by Wladimir Palant
Modified:
5 years, 3 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 1390 - Record referrer for download stats

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed Unicode hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M sitescripts/stats/bin/logprocessor.py View 1 chunk +4 lines, -3 lines 0 comments Download
M sitescripts/stats/common.py View 1 chunk +5 lines, -0 lines 0 comments Download
M sitescripts/stats/test/logprocessor.py View 1 10 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Wladimir Palant
5 years, 4 months ago (2014-09-17 20:47:34 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py File sitescripts/stats/test/logprocessor.py (right): http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py#newcode617 sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our strings are ...
5 years, 4 months ago (2014-09-18 15:50:04 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py File sitescripts/stats/test/logprocessor.py (right): http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py#newcode617 sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our strings are ...
5 years, 4 months ago (2014-09-18 18:42:50 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py File sitescripts/stats/test/logprocessor.py (right): http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py#newcode617 sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our strings are ...
5 years, 4 months ago (2014-09-19 09:48:42 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py File sitescripts/stats/test/logprocessor.py (right): http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/sitescripts/stats/test/logprocessor.py#newcode617 sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our strings are ...
5 years, 3 months ago (2014-09-22 10:39:04 UTC) #5
Sebastian Noack
5 years, 3 months ago (2014-09-22 10:39:39 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5