Issue #1147

installer/src/installer-lib/process.cpp

 #include <stdexcept>
 #include <functional>
 #include <wctype.h>
 // <thread> is C++11, but implemented in VS2012
 #include <thread>
 
 #include "installer-lib.h"
 #include "process.h"
 #include "handle.h"
 #include "session.h"
 
 //-------------------------------------------------------
 //-------------------------------------------------------
 typedef int (__stdcall *IsImmersiveDynamicFunc)(HANDLE);
 bool process_by_any_exe_not_immersive::operator()( const PROCESSENTRY32W & process )
 {
   if (processNames.find(process.szExeFile) != processNames.end())
   {   
     // Make sure the process is still alive
-    Windows_Handle procHandle = OpenProcess(PROCESS_QUERY_INFORMATION, FALSE, process.th32ProcessID);
-    if ((procHandle == NULL) || (procHandle == INVALID_HANDLE_VALUE)) return false;
+    HANDLE h = OpenProcess(PROCESS_QUERY_INFORMATION, FALSE, process.th32ProcessID);
+     // OpenProcess does not return INVALID_HANDLE VALUE, so a simple check is fine.

[Eric, 2014/07/31 15:37:08]

You can kill this comment in your own patch set.

+    if (!h) return false;

[Eric, 2014/07/31 15:44:24]

OOPS! This should be 'return true'. If the process is no longer available, it
certainly can't possibly be immersive. This addresses the condition where the
processNames member has been queried at a previous time and the process has
terminated in the interim. 

This odd-looking statement certainly deserves a comment above it. It wasn't
obvious to me; I make an error the first time.

+    Windows_Handle procHandle(h);
 
     DWORD exitCode;
     if (!GetExitCodeProcess(procHandle, &exitCode)) return false;
 
     if (exitCode != STILL_ACTIVE) return false;
 
     // Check if this is a Windows Store app process (we don't care for IE in Modern UI)
-    Windows_Module_Handle user32Dll(LoadLibrary(L"user32.dll"));
-    if (!user32Dll) return true;
+    HMODULE m = LoadLibrary(L"user32.dll");
+    if (!m) return true;
+    Windows_Module_Handle user32Dll(m);
 
     IsImmersiveDynamicFunc IsImmersiveDynamicCall = (IsImmersiveDynamicFunc)GetProcAddress(user32Dll, "IsImmersiveProcess");
     if (!IsImmersiveDynamicCall) return true;
 
     BOOL retValue = !IsImmersiveDynamicCall(procHandle);
 
     return retValue;
   }
   return false;
 }
@@ skipping 260 matching lines @@
       if ( ! is_running() )
       {
         return true ;
       }
     }
     // Assert is_running()
   }
   // No control path leaves the for-loop.
 } ;