filters/localise_path.py - Issue 4661048523096064: Issue 2120 - Add support for animations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: filters/localise_path.py

Issue 4661048523096064: Issue 2120 - Add support for animations. (Closed)

Patch Set: Forgot to give localise_path filter a default return! Created April 9, 2015, 8:44 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 # This file is part of the Adblock Plus website,

	2 # Copyright (C) 2006-2015 Eyeo GmbH

	3 #

	4 # Adblock Plus is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License version 3 as

	6 # published by the Free Software Foundation.

	7 #

	8 # Adblock Plus is distributed in the hope that it will be useful,

	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	11 # GNU General Public License for more details.

	12 #

	13 # You should have received a copy of the GNU General Public License

	14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	15

	16 import os

	17

	18 def localise_path(path, locale):
	Sebastian Noack 2015/04/10 07:55:46 Maybe it's just me. But I feel that British spelli Maybe it's just me. But I feel that British spelling ("-ise" instead "-ize") is quite uncommon in source code.
	19 for prefix in (("locales", locale), ("locales", "en"), ("static",)):

	20 full_path = os.path.join(*prefix + (path,))

	21 if os.path.isfile(full_path):
	Sebastian Noack 2015/04/10 07:55:46 Again, are you sure it's safe to resolve paths rel Again, are you sure it's safe to resolve paths relative to the CWD? And what's about platform-dependent path separators?
	22 return full_path

	23 return full_path

OLD	NEW