static/js/animation.js - Issue 4661048523096064: Issue 2120 - Add support for animations.

Delta Between Two Patch Sets: static/js/animation.js

Issue 4661048523096064: Issue 2120 - Add support for animations. (Closed)

Left Patch Set: Improved license header for animation.js. Created April 12, 2015, 5 p.m.

Right Patch Set: Addressed feedback. Created April 13, 2015, 9:03 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of the Adblock Plus website,	2 * This file is part of the Adblock Plus website,

3 * Copyright (C) 2007-2015 Wladimir Palant	3 * Copyright (C) 2006-2015 Eyeo GmbH
Wladimir Palant 2015/04/12 18:45:27 Eyeo GmbH please, I've transferred all the copyrig Eyeo GmbH please, I've transferred all the copyrights.
4 *	4 *

5 * This script is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify
Wladimir Palant 2015/04/12 18:45:27 This is now different from all our other license h This is now different from all our other license headers, including other license headers in this repository. As said in other reviews, we should keep things consistent. If we want to change our license headers, we should decide on a general approach rather than deciding for each file individually. kzar 2015/04/13 09:05:35 Done. Show quoted text On 2015/04/12 18:45:27, Wladimir Palant wrote: > This is now different from all our other license headers, including other > license headers in this repository. As said in other reviews, we should keep > things consistent. If we want to change our license headers, we should decide on > a general approach rather than deciding for each file individually. Done. Sebastian Noack 2015/04/13 09:41:50 Sure, but this file isn't part of Adblock Plus, bu Show quoted text On 2015/04/12 18:45:27, Wladimir Palant wrote: > This is now different from all our other license headers, including other > license headers in this repository. As said in other reviews, we should keep > things consistent. If we want to change our license headers, we should decide on > a general approach rather than deciding for each file individually. Sure, but this file isn't part of Adblock Plus, but of the Adblock Plus website as I pointed out earlier in this review. So wouldn't it be meaningless to declare Adblock Plus as free software under the terms of the GPL here? Sebastian Noack 2015/04/13 10:01:52 I just realized that we seem to use this header co Show quoted text On 2015/04/13 09:41:50, Sebastian Noack wrote: > On 2015/04/12 18:45:27, Wladimir Palant wrote: > > This is now different from all our other license headers, including other > > license headers in this repository. As said in other reviews, we should keep > > things consistent. If we want to change our license headers, we should decide > on > > a general approach rather than deciding for each file individually. > > Sure, but this file isn't part of Adblock Plus, but of the Adblock Plus website > as I pointed out earlier in this review. So wouldn't it be meaningless to > declare Adblock Plus as free software under the terms of the GPL here? I just realized that we seem to use this header consistently in the code here. So LGTM. But I still think that this header doesn't make much sense, and should probably be changed for all website files. Wladimir Palant 2015/04/14 16:58:51 Yes, that was the point. Unfortunately, I'm not a Show quoted text On 2015/04/13 10:01:52, Sebastian Noack wrote: > I just realized that we seem to use this header consistently in the code here. Yes, that was the point. Unfortunately, I'm not a lawyer and deciding what that header should look like isn't trivial. Too bad this isn't MPL 2.0 :-(
6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * This script is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 * GNU General Public License for more details.	12 * GNU General Public License for more details.

13 *	13 *

14 * You should have received a copy of the GNU General Public License	14 * You should have received a copy of the GNU General Public License

15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

16 */	16 */

17	17

18 if (typeof window.addEventListener != "undefined") {	18 if (typeof window.addEventListener != "undefined") {

19 window.addEventListener("load", initAnimations, false);	19 window.addEventListener("load", initAnimations, false);

(...skipping 320 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
340 if (/right/i.test(anchor))	340 if (/right/i.test(anchor))

341 coords[0] += size[0];	341 coords[0] += size[0];

342 else if (!/left/i.test(anchor))	342 else if (!/left/i.test(anchor))

343 coords[0] += Math.round(size[0]/2);	343 coords[0] += Math.round(size[0]/2);

344	344

345 if (/bottom/i.test(anchor))	345 if (/bottom/i.test(anchor))

346 coords[1] += size[1];	346 coords[1] += size[1];

347 else if (!/top/i.test(anchor))	347 else if (!/top/i.test(anchor))

348 coords[1] += Math.round(size[1]/2);	348 coords[1] += Math.round(size[1]/2);

349 }	349 }

LEFT	RIGHT