Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4702306650030080: Issue 2121 - Release automation fails to put generated packages into the right directory (Closed)

Created:
March 10, 2015, 7:17 p.m. by Wladimir Palant
Modified:
March 12, 2015, 4:45 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2121 - Release automation fails to put generated packages into the right directory

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M packager.py View 1 chunk +2 lines, -2 lines 0 comments Download
M packagerChrome.py View 1 chunk +1 line, -1 line 1 comment Download
M packagerGecko.py View 1 chunk +1 line, -1 line 0 comments Download
M packagerSafari.py View 1 chunk +1 line, -1 line 0 comments Download
M releaseAutomation.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
March 10, 2015, 7:17 p.m. (2015-03-10 19:17:41 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4702306650030080/diff/5629499534213120/packagerChrome.py File packagerChrome.py (right): http://codereview.adblockplus.org/4702306650030080/diff/5629499534213120/packagerChrome.py#newcode324 packagerChrome.py:324: outFile = getDefaultFileName(metadata, version, 'crx' if keyFile else 'zip') ...
March 10, 2015, 7:18 p.m. (2015-03-10 19:18:56 UTC) #2
Sebastian Noack
March 12, 2015, 9:51 a.m. (2015-03-12 09:51:24 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld