Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 4702306650030080: Issue 2121 - Release automation fails to put generated packages into the right directory (Closed)
Patch Set: Created March 10, 2015, 7:17 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packager.py ('k') | packagerGecko.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
===================================================================
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -316,17 +316,17 @@ def writePackage(outputFile, pubkey, sig
file.write(signature)
file.write(zipdata)
def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuild=False, keyFile=None, experimentalAPI=False, devenv=False):
metadata = readMetadata(baseDir, type)
version = getBuildVersion(baseDir, metadata, releaseBuild, buildNum)
if outFile == None:
- outFile = getDefaultFileName(baseDir, metadata, version, 'crx' if keyFile else 'zip')
+ outFile = getDefaultFileName(metadata, version, 'crx' if keyFile else 'zip')
Wladimir Palant 2015/03/10 19:18:56 This fixes another issue as a side-effect: when bu
params = {
'type': type,
'baseDir': baseDir,
'releaseBuild': releaseBuild,
'version': version,
'experimentalAPI': experimentalAPI,
'devenv': devenv,
« no previous file with comments | « packager.py ('k') | packagerGecko.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld