Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/org/adblockplus/android/compat/CmGlobalProxyManager.java

Issue 4705284891082752: Proxy configurators (Closed)
Left Patch Set: Created Aug. 11, 2014, 12:36 p.m.
Right Patch Set: Last batch of review issues Created Aug. 24, 2014, 11:52 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/org/adblockplus/android/Utils.java ('k') | src/org/adblockplus/android/compat/CompatibilityException.java » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 package org.adblockplus.android.compat; 18 package org.adblockplus.android.compat;
19 19
20 import android.app.Activity; 20 import android.app.Activity;
21 import android.content.Context; 21 import android.content.Context;
22 22
23 /** 23 /**
24 * Wrapper for CyanogenMod GlobalProxyManager API. 24 * Wrapper for CyanogenMod GlobalProxyManager API.
25 *
26 * @author rjeschke
Felix Dahlke 2014/08/19 09:06:00 We don't really do author tags so far. IMO there's
René Jeschke 2014/08/19 10:41:33 Right, auto-comments in Eclipse. Will remove those
27 */ 25 */
28 public class CmGlobalProxyManager 26 public class CmGlobalProxyManager
29 { 27 {
30 private final Object proxyManager; 28 private final Object proxyManager;
31 29
32 public final static String GLOBAL_PROXY_STATE_CHANGE_ACTION = "cyanogenmod.int ent.action.GLOBAL_PROXY_STATE_CHANGE"; 30 public final static String GLOBAL_PROXY_STATE_CHANGE_ACTION = "cyanogenmod.int ent.action.GLOBAL_PROXY_STATE_CHANGE";
33 31
34 public CmGlobalProxyManager(final Context context) throws CompatibilityExcepti on 32 public CmGlobalProxyManager(final Context context) throws CompatibilityExcepti on
35 { 33 {
36 try 34 try
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 { 114 {
117 try 115 try
118 { 116 {
119 return ProxyProperties.fromObject(this.proxyManager.getClass().getMethod(" getGlobalProxy") 117 return ProxyProperties.fromObject(this.proxyManager.getClass().getMethod(" getGlobalProxy")
120 .invoke(this.proxyManager)); 118 .invoke(this.proxyManager));
121 } 119 }
122 catch (final CompatibilityException ce) 120 catch (final CompatibilityException ce)
123 { 121 {
124 throw ce; 122 throw ce;
125 } 123 }
126 catch (Exception e) 124 catch (final Exception e)
127 { 125 {
128 throw new CompatibilityException(e); 126 throw new CompatibilityException(e);
129 } 127 }
130 } 128 }
131 } 129 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld