Unified Diff: firstRun.js
Issue 4731979438227456:
Issue 1663 - Emulate background page and implement proper message responder (Closed)
Patch Set: Properly convert Subscription objects as notification arguments
Created Dec. 17, 2014, 10:15 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« ext/content.js ('K')
|
« ext/content.js ('k')
|
messageResponder.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: firstRun.js |
| =================================================================== |
| --- a/firstRun.js |
| +++ b/firstRun.js |
| @@ -247,20 +247,23 @@ |
| { |
| ext.backgroundPage.sendMessage({type: "app.options"}); |
| } |
| function updateToggleButtons() |
| { |
| ext.backgroundPage.sendMessage({type: "subscriptions.get"}, function(subscriptions) |
| { |
| + var known = Object.create(null); |
| + for (var i = 0; i < subscriptions.length; i++) |
| + known[subscriptions[i].url] = true; |
| for (var i = 0; i < featureSubscriptions.length; i++) |
| { |
| var featureSubscription = featureSubscriptions[i]; |
| - updateToggleButton(featureSubscription.feature, subscriptions.indexOf(featureSubscription.url) >= 0); |
| + updateToggleButton(featureSubscription.feature, featureSubscription.url in known); |
| } |
| }); |
| } |
| function updateToggleButton(feature, isEnabled) |
| { |
| var button = E("toggle-" + feature); |
| if (isEnabled) |
« ext/content.js ('K')
|
« ext/content.js ('k')
|
messageResponder.js » ('j')
|
no next file with comments »
