firstRun.js - Issue 4731979438227456: Issue 1663 - Emulate background page and implement proper message responder

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: firstRun.js

Issue 4731979438227456: Issue 1663 - Emulate background page and implement proper message responder (Closed)

Patch Set: Rebased and addressed comments Created Dec. 18, 2014, 9:52 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: firstRun.js

===================================================================

--- a/firstRun.js

+++ b/firstRun.js

@@ -251,20 +251,23 @@

function updateToggleButtons()

{

ext.backgroundPage.sendMessage({

type: "subscriptions.get",

downloadable: true,

ignoreDisabled: true

}, function(subscriptions)

{

+ var known = Object.create(null);

+ for (var i = 0; i < subscriptions.length; i++)

+ known[subscriptions[i].url] = true;

for (var i = 0; i < featureSubscriptions.length; i++)

{

var featureSubscription = featureSubscriptions[i];

- updateToggleButton(featureSubscription.feature, subscriptions.indexOf(featureSubscription.url) >= 0);

+ updateToggleButton(featureSubscription.feature, featureSubscription.url in known);

}

});

}

function updateToggleButton(feature, isEnabled)

{

var button = E("toggle-" + feature);

if (isEnabled)

« no previous file with comments | « ext/content.js ('k') | messageResponder.js » ('j') | no next file with comments »