Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 4759471792324608: Issue 1712 - Don't add "Adblock Warning Removal List" subscription on Fennec (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by saroyanm
Modified:
4 years, 8 months ago
Reviewers:
Wladimir Palant
CC:
Philip Hill
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/1712

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/ui.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
saroyanm
Wladimir can you please have a look when you'll have time, also looks to be ...
4 years, 9 months ago (2014-12-22 00:11:58 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js#newcode820 lib/ui.js:820: if ((Services.vc.compare(prevVersion, "2.5") < 0) && !Utils.isFennec) I guess ...
4 years, 8 months ago (2015-01-06 13:18:12 UTC) #2
saroyanm
Updated http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js#newcode820 lib/ui.js:820: if ((Services.vc.compare(prevVersion, "2.5") < 0) && !Utils.isFennec) On ...
4 years, 8 months ago (2015-01-06 16:03:06 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js#newcode820 lib/ui.js:820: if ((Services.vc.compare(prevVersion, "2.5") < 0) && !Utils.isFennec) On 2015/01/06 ...
4 years, 8 months ago (2015-01-06 17:05:21 UTC) #4
saroyanm
http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/4759471792324608/diff/5629499534213120/lib/ui.js#newcode820 lib/ui.js:820: if ((Services.vc.compare(prevVersion, "2.5") < 0) && !Utils.isFennec) On 2015/01/06 ...
4 years, 8 months ago (2015-01-06 17:32:36 UTC) #5
Wladimir Palant
4 years, 8 months ago (2015-01-06 17:43:23 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5