Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1266)

Issue 4761138508070912: Issue 1848 - Clean up local reference handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by René Jeschke
Modified:
4 years, 5 months ago
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1848 - Clean up local reference handling

Patch Set 1 #

Patch Set 2 : Removed a Log.d #

Patch Set 3 : Some formatting issues #

Patch Set 4 : Removed member variable prefixes #

Total comments: 12

Patch Set 5 : Formatting, explicit, unrelated change #

Total comments: 4

Patch Set 6 : More formatting issues #

Patch Set 7 : Stupid auto-formatter^^ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -79 lines) Patch
M jni/JniCallbacks.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M jni/JniEventCallback.cpp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M jni/JniFilter.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M jni/JniFilterChangeCallback.cpp View 1 2 1 chunk +14 lines, -8 lines 0 comments Download
M jni/JniFilterEngine.cpp View 1 2 6 chunks +37 lines, -19 lines 0 comments Download
M jni/JniJsValue.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M jni/JniLogSystem.cpp View 1 2 3 4 5 6 2 chunks +17 lines, -8 lines 0 comments Download
M jni/JniUpdateAvailableCallback.cpp View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
M jni/JniUpdateCheckDoneCallback.cpp View 1 2 3 4 5 1 chunk +7 lines, -4 lines 0 comments Download
M jni/JniWebRequest.cpp View 1 2 3 4 5 2 chunks +32 lines, -13 lines 0 comments Download
M jni/Utils.h View 1 2 3 4 2 chunks +47 lines, -7 lines 0 comments Download
M jni/Utils.cpp View 1 2 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6
René Jeschke
I did not find the need to really use Push-/PopLocalFrame so it's only single reference ...
4 years, 5 months ago (2015-01-23 12:32:16 UTC) #1
Felix Dahlke
I'm not really happy we have to do this, but I don't see any better ...
4 years, 5 months ago (2015-02-03 05:22:49 UTC) #2
René Jeschke
http://codereview.adblockplus.org/4761138508070912/diff/5639274879778816/jni/JniEventCallback.cpp File jni/JniEventCallback.cpp (right): http://codereview.adblockplus.org/4761138508070912/diff/5639274879778816/jni/JniEventCallback.cpp#newcode44 jni/JniEventCallback.cpp:44: *JniLocalReference<jclass>(*env, On 2015/02/03 05:22:50, Felix H. Dahlke wrote: > ...
4 years, 5 months ago (2015-02-03 13:51:26 UTC) #3
Felix Dahlke
LGTM as-is, but some wrapping nits :P http://codereview.adblockplus.org/4761138508070912/diff/5639274879778816/jni/JniEventCallback.cpp File jni/JniEventCallback.cpp (right): http://codereview.adblockplus.org/4761138508070912/diff/5639274879778816/jni/JniEventCallback.cpp#newcode44 jni/JniEventCallback.cpp:44: *JniLocalReference<jclass>(*env, On ...
4 years, 5 months ago (2015-02-04 04:11:50 UTC) #4
René Jeschke
http://codereview.adblockplus.org/4761138508070912/diff/5639274879778816/jni/JniLogSystem.cpp File jni/JniLogSystem.cpp (right): http://codereview.adblockplus.org/4761138508070912/diff/5639274879778816/jni/JniLogSystem.cpp#newcode58 jni/JniLogSystem.cpp:58: default: On 2015/02/04 04:11:50, Felix H. Dahlke wrote: > ...
4 years, 5 months ago (2015-02-04 12:02:47 UTC) #5
Felix Dahlke
4 years, 5 months ago (2015-02-04 13:02:24 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5