Issue 1848 - Clean up local reference handling

jni/JniUpdateCheckDoneCallback.cpp

Index: jni/JniUpdateCheckDoneCallback.cpp
diff --git a/jni/JniUpdateCheckDoneCallback.cpp b/jni/JniUpdateCheckDoneCallback.cpp
index 817eb462e06a491168348df60b2ee8922d085710..87afb66539860b20d7f3d6ead340df3f590fb8eb 100644
--- a/jni/JniUpdateCheckDoneCallback.cpp
+++ b/jni/JniUpdateCheckDoneCallback.cpp
@@ -41,13 +41,15 @@ void JniUpdateCheckDoneCallback::Callback(const std::string& arg)
 {
   JNIEnvAcquire env(GetJavaVM());
 
-  jclass clazz = env->GetObjectClass(GetCallbackObject());
-  jmethodID method = env->GetMethodID(clazz, "updateCheckDoneCallback", "(Ljava/lang/String;)V");
+  jmethodID method = env->GetMethodID(
+      *JniLocalReference<jclass>(*env,
+          env->GetObjectClass(GetCallbackObject())), "updateCheckDoneCallback",

[Felix Dahlke, 2015/02/04 04:11:51]

Since you changed this in JniUpdateAvailableCallback.cpp - same thing here I'd
say.

[René Jeschke, 2015/02/04 12:02:47]

Done.

+      "(Ljava/lang/String;)V");
 
   if (method)
   {
-    jstring jArg = env->NewStringUTF(arg.c_str());
-    env->CallVoidMethod(GetCallbackObject(), method, jArg);
+    JniLocalReference<jstring> jArg(*env, env->NewStringUTF(arg.c_str()));
+    env->CallVoidMethod(GetCallbackObject(), method, *jArg);
   }
 
   CheckAndLogJavaException(*env);