Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: jni/JniUpdateAvailableCallback.cpp

Issue 4761138508070912: Issue 1848 - Clean up local reference handling (Closed)
Patch Set: Removed a Log.d Created Jan. 22, 2015, 6:56 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « jni/JniLogSystem.cpp ('k') | jni/JniUpdateCheckDoneCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jni/JniUpdateAvailableCallback.cpp
diff --git a/jni/JniUpdateAvailableCallback.cpp b/jni/JniUpdateAvailableCallback.cpp
index d8a4b2181e7dc96917137787029bc67bd3eb692e..7059cef72d6b97dd4b2d25b157b025de6db0523b 100644
--- a/jni/JniUpdateAvailableCallback.cpp
+++ b/jni/JniUpdateAvailableCallback.cpp
@@ -41,14 +41,14 @@ void JniUpdateAvailableCallback::Callback(const std::string& arg)
{
JNIEnvAcquire env(GetJavaVM());
- jclass clazz = env->GetObjectClass(GetCallbackObject());
- jmethodID method = env->GetMethodID(clazz, "updateAvailableCallback",
- "(Ljava/lang/String;)V");
+ jmethodID method = env->GetMethodID(
+ *JniLocalReference<jclass>(*env, env->GetObjectClass(GetCallbackObject())),
+ "updateAvailableCallback", "(Ljava/lang/String;)V");
if (method)
{
- jstring jArg = env->NewStringUTF(arg.c_str());
- env->CallVoidMethod(GetCallbackObject(), method, jArg);
+ JniLocalReference<jstring> jArg(*env, env->NewStringUTF(arg.c_str()));
+ env->CallVoidMethod(GetCallbackObject(), method, *jArg);
}
CheckAndLogJavaException(*env);
« no previous file with comments | « jni/JniLogSystem.cpp ('k') | jni/JniUpdateCheckDoneCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld