Element Hiding Helper inspector tool fix

lib/inspectorObserver.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
-Cu.import("resource:///modules/devtools/gDevTools.jsm");
+let {gDevTools} = Cu.import("resource:///modules/devtools/gDevTools.jsm", null);
 
 let InspectorObserver =
 {
   init: function()
   {
     gDevTools.on("inspector-ready", this.inspectorReady);
     onShutdown.add(function()
     {
       gDevTools.off("inspector-ready", this.inspectorReady);
     }.bind(this));
   },
 
   get inspectorButton()

[saroyanm, 2014/04/12 20:59:38]

Not sure if it's make sense to change getter into inspectorButtonTooltip ?

[Wladimir Palant, 2014/04/12 21:05:21]

Yes, I think the name should be changed.

   {
     // Randomize URI to work around bug 719376
     let stringBundle = Services.strings.createBundle("chrome://elemhidehelper/locale/global.properties?" + Math.random());
-    let result = [stringBundle.GetStringFromName("inspector.button.label"), stringBundle.GetStringFromName("inspector.button.accesskey"), stringBundle.GetStringFromName("inspector.button.tooltiptext")];
+    let result = stringBundle.GetStringFromName("inspector.button.tooltiptext");
 
     delete this.inspectorButton;
     this.__defineGetter__("inspectorButton", function() result);
     return this.inspectorButton;
   },
   
-  inspectorReady: function(eventName, listener)
+  inspectorReady: function(eventName, toolbox, panel)
   {
-    let toolbox = gDevTools.getToolbox(listener.target);
-    if (!toolbox)
+    let panelWindow = panel.panelWin;
+    let inspectBtn = panelWindow.document.getElementById("inspector-inspect-toolbutton");
+    if (!inspectBtn)
       return;
     
-    let panel = toolbox.getToolPanels().get("inspector");
-    if (!panel)
-      return;
-    
-    let panelWindow = panel.panelWin;
-    let parent = panelWindow.document.getElementById("inspector-toolbar");
-    if (!parent)
-      return;
-    
-    let [label, accesskey, tooltiptext] = InspectorObserver.inspectorButton;
+    let tooltiptext = InspectorObserver.inspectorButton;
     button = panelWindow.document.createElement("toolbarbutton");
     button.setAttribute("id", "inspector-abp-elemhide-toolbutton");
-    button.setAttribute("label", label);
+    button.style.listStyleImage = "url('chrome://adblockplus/skin/abp-status-16.png')";
+    button.style.MozImageRegion = "rect(0px, 16px, 16px, 0px)";
+    button.style.paddingTop = "4px";
     button.setAttribute("class", "devtools-toolbarbutton");
     button.setAttribute("accesskey", accesskey);
     button.setAttribute("tooltiptext", tooltiptext);
     button.setAttribute("tabindex", "0");
     button.addEventListener("command", function()
     {
       panelWindow.openDialog("chrome://elemhidehelper/content/composer.xul", "_blank", 
                              "chrome,centerscreen,resizable,dialog=no", panel.selection.node);
     }, false);
-    parent.appendChild(button);
+    inspectBtn.parentNode.insertBefore(button, inspectBtn.nextSibling);
   }
 };
 
 InspectorObserver.init();