Case-insensitive string class

installer/src/custom-action/close_application.cpp

 /**
  * \file close_application.cpp
  */
 
 #include <algorithm>
 
 #include "session.h"
 #include "property.h"
 #include "database.h"
 #include "process.h"
 #include "interaction.h"
 #include "custom-i18n.h"
 
 //-------------------------------------------------------
 //-------------------------------------------------------
 class IE_Closer
 {
   Snapshot snapshot ;
 
   Process_Closer ie_closer ;
 
   Process_Closer engine_closer ;
 
-  static const wchar_t * ie_names[] ;
-  static const wchar_t * engine_names[] ;
+  static const wchar_t * ie_names[ 1 ] ;
+  static const wchar_t * engine_names[ 1 ] ;

[Wladimir Palant, 2014/03/31 05:58:35]

Style nit: excessive whitespace. There should be no whitespace between * or
inside square brackets. Also, there should be no space before a semicolon. Same
elsewhere, not going to repeat.

 
 public:
   IE_Closer()
-    : snapshot(), ie_closer( snapshot, ie_names, 1 ), engine_closer( snapshot, engine_names, 1 )
+    : snapshot(), ie_closer( snapshot, ie_names ), engine_closer( snapshot, engine_names )

[Wladimir Palant, 2014/03/31 05:58:35]

Style nit: excessive whitespace. There should be no space before or after a
parameter list (same elsewhere, not going to repeat).

   {}
 
   void refresh()
   {
     snapshot.refresh() ;
     ie_closer.refresh() ;
     engine_closer.refresh() ;
   }
 
   bool is_running()
@@ skipping 12 matching lines @@
     if ( engine_closer.is_running() && ! engine_closer.shut_down() )
     {
       // Assert the engine is still running
       // This is after IE has shut down itself and after we've tried to shut down the engine. Whatever.
       return false ;
     }
     return true ;
   }
 } ;
 
-const wchar_t * IE_Closer::ie_names[] = { L"IExplore.exe" } ;
-const wchar_t * IE_Closer::engine_names[] = { L"AdblockPlusEngine.exe" } ;
+const wchar_t * IE_Closer::ie_names[ 1 ] = { L"IExplore.exe" } ;
+const wchar_t * IE_Closer::engine_names[ 1 ] = { L"AdblockPlusEngine.exe" } ;
 
 //-------------------------------------------------------
 // abp_close_ie
 //-------------------------------------------------------
 /**
  * Exposed DLL entry point for custom action. 
  * The function signature matches the calling convention used by Windows Installer.
  *
  * This function supports four policy stances with respect to a running IE process.
  *
@@ skipping 377 matching lines @@
   return TRUE ;
 }
 
 /**
  * Windows_List
  */
 class Window_List {
 public:
   void enumerate_top_level();
 };