Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(436)

Issue 4790980679041024: Issue 2268 - Deprecate setupStderr() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Sebastian Noack
Modified:
4 years, 10 months ago
Reviewers:
Wladimir Palant
CC:
kzar, mathias
Visibility:
Public.

Description

Issue 2268 - Deprecate setupStderr()

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improved warning text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M sitescripts/__init__.py View 1 chunk +25 lines, -0 lines 0 comments Download
M sitescripts/utils.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
4 years, 10 months ago (2015-04-09 20:43:27 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4790980679041024/diff/5629499534213120/sitescripts/utils.py File sitescripts/utils.py (right): http://codereview.adblockplus.org/4790980679041024/diff/5629499534213120/sitescripts/utils.py#newcode89 sitescripts/utils.py:89: 'writing to stderr is problematic use the ' Maybe ...
4 years, 10 months ago (2015-04-09 21:09:02 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4790980679041024/diff/5629499534213120/sitescripts/utils.py File sitescripts/utils.py (right): http://codereview.adblockplus.org/4790980679041024/diff/5629499534213120/sitescripts/utils.py#newcode89 sitescripts/utils.py:89: 'writing to stderr is problematic use the ' On ...
4 years, 10 months ago (2015-04-09 21:19:04 UTC) #3
Wladimir Palant
4 years, 10 months ago (2015-04-09 21:27:09 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5