Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 4799232384958464: Issue 2299 - Add adwarefilters to the filtermaster (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Felix Dahlke
Modified:
4 years, 9 months ago
Visibility:
Public.

Description

Issue 2299 - Add adwarefilters to the filtermaster

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add trailing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M modules/filtermaster/files/sitescripts View 1 chunk +1 line, -0 lines 0 comments Download
M modules/filtermaster/manifests/init.pp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Felix Dahlke
4 years, 9 months ago (2015-04-29 08:40:01 UTC) #1
mathias
LGTM.
4 years, 9 months ago (2015-04-29 08:42:08 UTC) #2
Wladimir Palant
LGTM, up to you whether you want to address the nit. http://codereview.adblockplus.org/4799232384958464/diff/5629499534213120/modules/filtermaster/manifests/init.pp File modules/filtermaster/manifests/init.pp (right): ...
4 years, 9 months ago (2015-04-29 16:09:01 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/4799232384958464/diff/5629499534213120/modules/filtermaster/manifests/init.pp File modules/filtermaster/manifests/init.pp (right): http://codereview.adblockplus.org/4799232384958464/diff/5629499534213120/modules/filtermaster/manifests/init.pp#newcode113 modules/filtermaster/manifests/init.pp:113: 'adwarefilters' On 2015/04/29 16:09:01, Wladimir Palant wrote: > Nit: ...
4 years, 9 months ago (2015-04-29 16:20:14 UTC) #4
Wladimir Palant
4 years, 9 months ago (2015-04-29 17:37:46 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5