src/shared/Utils.h - Issue 4806567450902528: Issue 1794 - add handling of std::vector<std::string> by Communication::{Input,Output}Buffer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/shared/Utils.h

Issue 4806567450902528: Issue 1794 - add handling of std::vector<std::string> by Communication::{Input,Output}Buffer (Closed)

Patch Set: remove WriteStrings and ReadStrings Created Feb. 9, 2015, 2:04 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/shared/Utils.h

diff --git a/src/shared/Utils.h b/src/shared/Utils.h

index c437cf2d98b6091dd161107ce86fb905b63d4ad8..b8f33e71fd13869d127be90bd5f66fd4a8013b87 100644

--- a/src/shared/Utils.h

+++ b/src/shared/Utils.h

@@ -5,6 +5,7 @@

#include <locale>

#include <functional>

#include <string>

+#include <vector>

#define WM_ALREADY_UP_TO_DATE WM_APP+1

#define WM_UPDATE_CHECK_ERROR WM_APP+2

@@ -35,6 +36,7 @@ bool IsWindows8OrLater();

std::string ToUtf8String(const std::wstring& str);

std::wstring ToUtf16String(const std::string& str);

+std::vector<std::wstring> ToUtf16Strings(const std::vector<std::string>& value);

Eric 2015/02/09 16:18:57 Where's the other half of the pair ToUtf8Strings?

sergei 2015/02/09 16:55:37 We don't need, it would be a dead code.

std::wstring GetDllDir();

std::wstring GetAppDataPath();

void ReplaceString(std::wstring& input, const std::wstring placeholder, const std::wstring replacement);