Issue 122 - Puppet ENC via Hiera

Vagrantfile

 require 'yaml'
 
 VAGRANTFILE_API_VERSION = "2"
 REPOSITORY_DIR = File.dirname(__FILE__)
 DEPENDENCY_SCRIPT = File.join(REPOSITORY_DIR, "ensure_dependencies.py")
 
 if !system("python", DEPENDENCY_SCRIPT)
   error = Vagrant::Errors::VagrantError
   error.error_message("Failed to ensure dependencies being up-to-date!")
   raise error
 end
 
 def define_standard_vm(config, host_name, ip, role=nil)
   config.vm.define host_name do |config|
-
     config.vm.box = 'precise64'
     config.vm.box_url = 'http://cloud-images.ubuntu.com/vagrant/precise/current/precise-server-cloudimg-amd64-vagrant-disk1.box'
     config.vm.host_name = "#{host_name}.adblockplus.org"
     config.vm.network :private_network, ip: ip
     config.vm.provider :virtualbox do |vb|
-
       vb.customize ["modifyvm", :id, "--cpus", 1]
 
       # Work around https://www.virtualbox.org/ticket/11649
       vb.customize ['modifyvm', :id, '--natdnshostresolver1', 'on']
 
-      if role == nil

[Wladimir Palant, 2014/11/17 16:43:36]

Can role ever be nil? I don't think we want to have host-specific configuration,
all hosts are configured according to their role (which can be assigned to zero,
one or many hosts).

[mathias, 2014/11/27 00:30:18]

Agreed, we do not need a host being configured by itself (though I still see a
use for additional, host-specific setup - especially when different server
hardware operates in a cluster). 

Note, however, that due to various limitations (in Ruby, Puppet and Hiera
itself) it is not trivial at all to properly merge multiple roles into each
other - which is why only "zero" or "one" role can be assigned - multiple ones
have to be combined by creating another role.

-        setup_path = File.join(Dir.pwd, "hiera", "hosts", "#{host_name}.yaml")

[Wladimir Palant, 2014/11/17 16:43:36]

Please don't use Dir.pwd here or elsewhere, its value is "random" -
REPOSITORY_DIR should be used instead.

[mathias, 2014/11/27 00:30:18]

Done.

-      else
-        setup_path = File.join(Dir.pwd, "hiera", "roles", "#{role}.yaml")
-      end
-
+      setup_path = File.join(REPOSITORY_DIR, "hiera", "roles", "#{role}.yaml")
       setup = YAML.load_file(setup_path) rescue {}
       requirements = setup.fetch("requirements", {})
 
       requirements.each do |key, value|
         vb.customize ['modifyvm', :id, "--#{key}", "#{value}"]
       end
 
     end
 
     # The repository location in the production system's puppet master
     config.vm.synced_folder ".", "/etc/puppet/infrastructure"
 
     config.vm.provision :shell, :inline => '
-      sudo /etc/puppet/infrastructure/hiera/install-precise.py
+      sudo /etc/puppet/infrastructure/hiera/install_precise.py
     '
 
     config.vm.provision :puppet do |puppet|
       puppet.options = [
         '--environment=development',
-        '--external_nodes=/etc/puppet/infrastructure/hiera/puppet-node-classifier.rb',
+        '--external_nodes=/etc/puppet/infrastructure/hiera/puppet_node_classifier.rb',
         '--node_terminus=exec',
         '--verbose',
         '--debug',

[Wladimir Palant, 2014/11/17 16:43:36]

Debug output isn't going to be too useful, right?

[mathias, 2014/11/27 00:30:18]

It is super useful! It doesn't seem to make much sense running Puppet from
Vagrant without the debug option: When something fails during development or
test, one may not be able to determine the exact reason without the debug output
and thus be forced to re-play the entire scenario (which may not be an exact
replay as some states may have changed already etc). In fact it happens so often
- especially when some ordering went wrong - that one gets annoyed by not having
the debug output in the first place. Also there's no guarantee unordered parts
are executed the same way again. 

To make a long story short: I am absolutely sure we (read "Alfonso, Paco and
Matze, at least") do want the option set here by default. And no, the verbose
option alone is, in many cases, not enough..

       ]
       puppet.manifests_path = 'manifests'
       puppet.manifest_file = 'nodes.pp'
       puppet.module_path = 'modules'
-      # Requires Puppet 3.x or later
-      #puppet.hiera_config_path = 'hiera/vagrant.yaml'
     end
 
     yield(config) if block_given?
-
   end
 end
 
 Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
-  configYAML = File.join(Dir.pwd, "hiera/environment/hosts.yaml")
-  configServers = YAML.load_file(configYAML)
-  servers = configServers["servers"]
+  config_path = File.join(REPOSITORY_DIR, "hiera/private/hosts.yaml")
+  config_data = YAML.load_file(config_path)
+  servers = config_data["servers"]
   servers.each do |server, items|
     ip = items["ip"][0]
     role = items.fetch("role", "default")
     define_standard_vm(config, server, ip, role)
   end
 end