adblock-browser.html - Issue 4814987935612928: Issue 2213 - landing page for mobile beta launch

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: adblock-browser.html

Issue 4814987935612928: Issue 2213 - landing page for mobile beta launch (Closed)

Patch Set: Created April 21, 2015, 10:46 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <h3>Join the beta test!</h3>

	2

	3 <ol>

	4 <li>Join the <b>Adblock Browser for Android Beta</b> Google+ community.</li>

	5 <li>Click the <b>Become a Tester</b> link.</li>

	6 <li>Download the <b>beta app</b>.</li>

	7 </ol>

	8

	9 <a href="https://plus.google.com/u/1/communities/112291714220563111060" class="b utton-community">Beta test Adblock Browser for Android</a>

	10

	11 <h3 class="subscribe-header">iOS user? Coming soon!</h3>

	12

	13 <p class="subscribe-description">

	14 Get a heads-up prior to the launch!

	15 </p>

	16

	17 <form id="subscribe-form" action="/submitEmail" method="post">

	18 <input id="subscribe-textbox" type="email" name="email" placeholder="Your emai l address" />
	Thomas Greiner 2015/04/21 13:31:45 Text in attributes are not translatable. Use `<att Text in attributes are not translatable. Use `<attr>` for that. For example replace <input ... placeholder="Your email address" /> with <input ...><attr name="placeholder">Your email address</attr></input> saroyanm 2015/04/22 15:27:08 Done. Show quoted text On 2015/04/21 13:31:45, Thomas Greiner wrote: > Text in attributes are not translatable. Use `<attr>` for that. For example > replace > > <input ... placeholder="Your email address" /> > > with > > <input ...><attr name="placeholder">Your email address</attr></input> Done.
	19 <input id="subscribe-button" type="submit" value="Notify me" />
	Thomas Greiner 2015/04/21 13:31:45 Same issue with translations as above. Alternative Same issue with translations as above. Alternatively, you could change this one to <button id="subscribe-button">Notify me</button> saroyanm 2015/04/22 15:27:08 Done. Show quoted text On 2015/04/21 13:31:45, Thomas Greiner wrote: > Same issue with translations as above. Alternatively, you could change this one > to > > <button id="subscribe-button">Notify me</button> Done.
	20 <span class="sucess-label">

	21 A confirmation email has been sent. Please check your email and click the co nfirmation link.

	22 </span>

	23 <span class="empty-label">
	Sebastian Noack 2015/04/22 07:52:45 Didn't we agree to leave validation up to the brow Didn't we agree to leave validation up to the browser? Using <input type="email" required> should make those messages obsolete. saroyanm 2015/04/22 15:27:08 Oops, thanks for required reminder, anyway as I me Show quoted text On 2015/04/22 07:52:45, Sebastian Noack wrote: > Didn't we agree to leave validation up to the browser? Using <input type="email" > required> should make those messages obsolete. Oops, thanks for required reminder, anyway as I mentioned in my comment to the JS section I tried to make changes compatible with IE 8 as well and make texts translatable as well for browsers that doesn't support inputs of type email.
	24 Oops! You didn't enter your email address.

	25 </span>

	26 <span class="invalid-label">

	27 Invalid email address.

	28 </span>

	29 <span id="response-error">

	30 </span>

	31 </form>

	32

	33 <div class="disclaimer lang-fr">

	34 <fix>En téléchargeant le logiciel Adblock Plus vous acceptez que si vous utili sez Adblock Plus pour visiter un site Internet en violation de toute obligation ou droit de quelque nature que ce soit en relation avec ce site Internet, en auc un cas EYEO ne pourra être tenu pour responsable envers vous ou tout autre tiers pour toute perte ou dommage (y compris, sans y être limité, les dommages pour p erte de chances et perte de bénéfices) découlant directement ou indirectement de votre utilisation de ce logiciel.</fix>

	35 </div>

OLD	NEW

« no previous file with comments | « no previous file | adblock-browser-head.html » ('j') | adblock-browser-head.html » ('J')