adblock-browser.html - Issue 4814987935612928: Issue 2213 - landing page for mobile beta launch

Side by Side Diff: adblock-browser.html

Issue 4814987935612928: Issue 2213 - landing page for mobile beta launch (Closed)

Patch Set: Remove client side email validation Created April 23, 2015, 5 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <h3>Join the beta test!</h3>

	2

	3 <ol>

	4 <li>Join the <b>Adblock Browser for Android Beta</b> Google+ community.</li>

	5 <li>Click the <b>Become a Tester</b> link.</li>

	6 <li>Download the <b>beta app</b>.</li>

	7 </ol>

	8

	9 <div class="button-community-wrapper">

	10 <a href="https://plus.google.com/u/1/communities/112291714220563111060">Beta t est Adblock Browser for Android</a>

	11 </div>

	12

	13 <h3 class="subscribe-header">iOS user? Coming soon!</h3>

	14

	15 <p class="subscribe-description">

	16 Get a heads-up prior to the launch!

	17 </p>

	18

	19 <form id="subscribe-form" accept-charset="utf-8" action="/submitEmail" method="p ost">

	20 <input id="subscribe-textbox" type="email" name="email" required=""><attr name ="placeholder">Your email address</attr></input>
	Sebastian Noack 2015/04/24 10:22:58 Nit: You don't need to specify a value for the req Nit: You don't need to specify a value for the required attribute, you can specify it just like <input required> saroyanm 2015/04/24 14:56:31 The case is the Anwiki invalidates the content and Show quoted text On 2015/04/24 10:22:58, Sebastian Noack wrote: > Nit: You don't need to specify a value for the required attribute, you can > specify it just like <input required> The case is the Anwiki invalidates the content and don't allow publishing, this is a hack for Anwiki. Sebastian Noack 2015/04/24 15:46:10 I see. But consider filing a follow-up issue, to r Show quoted text On 2015/04/24 14:56:31, saroyanm wrote: > On 2015/04/24 10:22:58, Sebastian Noack wrote: > > Nit: You don't need to specify a value for the required attribute, you can > > specify it just like <input required> > > The case is the Anwiki invalidates the content and don't allow publishing, this > is a hack for Anwiki. I see. But consider filing a follow-up issue, to remove this and similar hacks after the migration.
	21 <button id="subscribe-button" type="submit"><span>Notify me</span></button>

	22 <span class="sucess-label">

	23 A confirmation email has been sent. Please check your email and click the co nfirmation link.

	24 </span>

	25 <span class="empty-label">

	26 Oops! You didn't enter your email address.
	saroyanm 2015/04/23 17:13:43 @Sebastian please note that I kept this error mess @Sebastian please note that I kept this error message. Please let me know if you are okey to keep it here, I think it could be useful to inform user that he need to enter email not to show "Invalid email address." message. Please let me know if you are okey with it. Sebastian Noack 2015/04/24 09:54:50 I'd rather merge those error messages together lik Show quoted text On 2015/04/23 17:13:43, saroyanm wrote: > @Sebastian please note that I kept this error message. Please let me know if you > are okey to keep it here, I think it could be useful to inform user that he need > to enter email not to show "Invalid email address." message. Please let me know > if you are okey with it. I'd rather merge those error messages together like: Oops! You didn't enter a valid email address. Then you can get rid of the logic handling empty values as well, just showing this message whenever the server responds with status code 400. saroyanm 2015/04/24 14:56:31 Done. Show quoted text On 2015/04/24 09:54:50, Sebastian Noack wrote: > On 2015/04/23 17:13:43, saroyanm wrote: > > @Sebastian please note that I kept this error message. Please let me know if > you > > are okey to keep it here, I think it could be useful to inform user that he > need > > to enter email not to show "Invalid email address." message. Please let me > know > > if you are okey with it. > > I'd rather merge those error messages together like: > > Oops! You didn't enter a valid email address. > > Then you can get rid of the logic handling empty values as well, just showing > this message whenever the server responds with status code 400. Done.
	27 </span>

	28 <span class="invalid-label">

	29 Invalid email address.

	30 </span>

	31 <span id="response-error">

	32 </span>

	33 </form>

	34

	35 <div class="disclaimer lang-fr">

	36 <fix>En téléchargeant le logiciel Adblock Plus vous acceptez que si vous utili sez Adblock Plus pour visiter un site Internet en violation de toute obligation ou droit de quelque nature que ce soit en relation avec ce site Internet, en auc un cas EYEO ne pourra être tenu pour responsable envers vous ou tout autre tiers pour toute perte ou dommage (y compris, sans y être limité, les dommages pour p erte de chances et perte de bénéfices) découlant directement ou indirectement de votre utilisation de ce logiciel.</fix>

	37 </div>

	38

	39 <span id="email-placeholder">Your email address</span>

OLD	NEW

« no previous file with comments | « no previous file | adblock-browser-head.html » ('j') | adblock-browser-head.html » ('J')