adblock-browser.html - Issue 4814987935612928: Issue 2213 - landing page for mobile beta launch

Delta Between Two Patch Sets: adblock-browser.html

Issue 4814987935612928: Issue 2213 - landing page for mobile beta launch (Closed)

Left Patch Set: Nit fixes Created April 24, 2015, 3:53 p.m.

Right Patch Set: Make meta tags translatable Created April 29, 2015, 1:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
	1 <meta name="title"><attr name="content">Adblock Browser Beta Launch</attr></meta >

	2 <meta property="og:title"><attr name="content">Adblock Browser Beta Launch</attr ></meta>

	3 <meta name="description"><attr name="content">Want Adblock Browser for your smar tphone or tablet? Join the Adblock Browser for Android Beta Google+ community.</ attr></meta>

	4 <meta property="og:description"><attr name="content">Want Adblock Browser for yo ur smartphone or tablet? Join the Adblock Browser for Android Beta Google+ commu nity.</attr></meta>

	5

1 <h3>Join the beta test!</h3>	6 <h3>Join the beta test!</h3>

2	7

3 <ol>	8 <ol>

4 <li>Join the <b>Adblock Browser for Android Beta</b> Google+ community.</li>	9 <li>Join the <b>Adblock Browser for Android Beta</b> Google+ community.</li>

5 <li>Click the <b>Become a Tester</b> link.</li>	10 <li>Click the <b>Become a Tester</b> link.</li>

6 <li>Download the <b>beta app</b>.</li>	11 <li>Download the <b>beta app</b>.</li>

7 </ol>	12 </ol>

8	13

9 <div class="button-community-wrapper">	14 <div class="button-community-wrapper">

10 <a href="https://plus.google.com/u/1/communities/112291714220563111060">Beta t est Adblock Browser for Android</a>	15 <a href="https://plus.google.com/u/1/communities/112291714220563111060">Beta t est Adblock Browser for Android</a>

11 </div>	16 </div>

12	17

13 <h3 class="subscribe-header">iOS user? Coming soon!</h3>	18 <h3 class="subscribe-header">iOS user? Coming soon!</h3>

14	19

15 <p class="subscribe-description">	20 <p class="subscribe-description">

16 Get a heads-up prior to the launch!	21 Get a heads-up prior to the launch!

17 </p>	22 </p>

18	23

19 <form id="subscribe-form" accept-charset="utf-8" action="/submitEmail" method="p ost">	24 <form id="subscribe-form" accept-charset="utf-8" action="/submitEmail" method="p ost">

20 <input id="subscribe-textbox" type="email" name="email" required=""><attr name ="placeholder">Your email address</attr></input>	25 <input id="subscribe-textbox" type="email" name="email" required=""><attr name ="placeholder">Your email address</attr></input>
saroyanm 2015/04/27 15:24:51 Okey so in that case I should extract language fro Show quoted text On 2015/04/27 15:12:53, Sebastian Noack wrote: > On 2015/04/27 14:57:29, saroyanm wrote: > > On 2015/04/27 14:24:34, Sebastian Noack wrote: > > > While reviewing the server-side, we just realized that we should pass the > > > language, in order to show the landing page the user is redirected to, after > > > clicking the verification link, in the same language. > > > > > > Therefore, the server is expecting now as well a field with the name "lang" > to > > > indicate that language. So you have to add an <input name="lang" > > type="hidden"> > > > here. The language provided by that field should relate to the language part > > of > > > the URL. > > > > Why don't we want to use Referer for that case ? > > Then we would need to make assumptions about the URLs in he backend, and have to > rely on the Referer header. Not that great, if we can just pass the language > code from the client-side. Okey so in that case I should extract language from URL, this should be done in JS. I think doesn't make sense to consider the case of people visiting website without enabled JS. I think back end script can still check if the language is missing to redirect them to English version of the website. Sebastian Noack 2015/04/27 15:33:09 Sure, if this needs to be done with JavaScript, th Show quoted text On 2015/04/27 15:24:51, saroyanm wrote: > On 2015/04/27 15:12:53, Sebastian Noack wrote: > > On 2015/04/27 14:57:29, saroyanm wrote: > > > On 2015/04/27 14:24:34, Sebastian Noack wrote: > > > > While reviewing the server-side, we just realized that we should pass the > > > > language, in order to show the landing page the user is redirected to, > after > > > > clicking the verification link, in the same language. > > > > > > > > Therefore, the server is expecting now as well a field with the name > "lang" > > to > > > > indicate that language. So you have to add an <input name="lang" > > > type="hidden"> > > > > here. The language provided by that field should relate to the language > part > > > of > > > > the URL. > > > > > > Why don't we want to use Referer for that case ? > > > > Then we would need to make assumptions about the URLs in he backend, and have > to > > rely on the Referer header. Not that great, if we can just pass the language > > code from the client-side. > > Okey so in that case I should extract language from URL, this should be done in > JS. > I think doesn't make sense to consider the case of people visiting website > without enabled JS. > I think back end script can still check if the language is missing to redirect > them to English version of the website. Sure, if this needs to be done with JavaScript, there is no point actually adding a hidden field here. But we can just add the "lang" field to the request when preparing the XHR. If the lang parameter is omitted, the backend already falls back to "en". Sebastian Noack 2015/04/27 18:30:43 We need the language as used in the URL. That the Show quoted text On 2015/04/27 15:44:26, Thomas Greiner wrote: > > > Okey so in that case I should extract language from URL, this should be done > > in > > > JS. > > We don't need to parse the URL to get the language. It's already provided in > `<html lang="...">`. We need the language as used in the URL. That the "lang" attribute uses underscores (instead hyphens) as well is a bug, we shouldn't rely on here.
21 <button id="subscribe-button" type="submit"><span>Notify me</span></button>	26 <button id="subscribe-button" type="submit"><span>Notify me</span></button>

22 <span class="sucess-label">	27 <span class="sucess-label">

23 A confirmation email has been sent. Please check your email and click the co nfirmation link.	28 A confirmation email has been sent. Please check your email and click the co nfirmation link.

24 </span>	29 </span>

25 <span class="invalid-label">	30 <span class="invalid-label">

26 Please enter a valid email address.	31 Please enter a valid email address.

27 </span>	32 </span>

28 <span id="response-error">	33 <span id="response-error">

29 </span>	34 </span>

30 </form>	35 </form>

31	36

32 <div class="disclaimer lang-fr">	37 <div class="disclaimer lang-fr">

33 <fix>En téléchargeant le logiciel Adblock Plus vous acceptez que si vous utili sez Adblock Plus pour visiter un site Internet en violation de toute obligation ou droit de quelque nature que ce soit en relation avec ce site Internet, en auc un cas EYEO ne pourra être tenu pour responsable envers vous ou tout autre tiers pour toute perte ou dommage (y compris, sans y être limité, les dommages pour p erte de chances et perte de bénéfices) découlant directement ou indirectement de votre utilisation de ce logiciel.</fix>	38 <fix>En téléchargeant le logiciel Adblock Plus vous acceptez que si vous utili sez Adblock Plus pour visiter un site Internet en violation de toute obligation ou droit de quelque nature que ce soit en relation avec ce site Internet, en auc un cas EYEO ne pourra être tenu pour responsable envers vous ou tout autre tiers pour toute perte ou dommage (y compris, sans y être limité, les dommages pour p erte de chances et perte de bénéfices) découlant directement ou indirectement de votre utilisation de ce logiciel.</fix>

34 </div>	39 </div>

LEFT	RIGHT