Issue 4817131468226560: Added site_url template variable in order to help generating pages that require a full absolute URL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4817131468226560: Added site_url template variable in order to help generating pages that require a full absolute URL (Closed)

Created:
Feb. 4, 2014, 11:32 a.m. by Sebastian Noack

Modified:
Feb. 7, 2014, 4:13 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

This is needed in order to add javascript license information, via Web Labels: http://codereview.adblockplus.org/6272077409550336/ http://codereview.adblockplus.org/5748228838391808/ JavaScript Web Labels must list all external scripts used on the website, with their absolute URL (including domain). And hard-coding the base URL in the template would be a bad idea, because of the URL would be wrong when running the website locally. And so you can't test.

Patch Set 1 #

Created: Feb. 4, 2014, 11:32 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	sitescripts/cms/bin/test_server.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sitescripts/cms/utils.py	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages