Issue 2472 - Have https://eyeo.com/jobs redirect properly

modules/web/templates/site.conf.erb

 expires 1d;
 
 root /var/www/<%= vhost %>;
 index index;
 default_type text/html;
 charset utf-8;
 
 set $index_page "index";
 
 <% if @custom_config %>
@@ skipping 10 matching lines @@
   {
     set $preferredLang $1;
   }
   if ($http_accept_language ~ ^\w\w-(\w\w)\b)
   {
     set $preferredRegion $1;
   }
 
   # Redirect canonical URLs to language-specific versions
 
-  if (-f "$document_root/${preferredLang}_$preferredRegion$uri")
+  if (-e "$document_root/${preferredLang}_$preferredRegion$uri")
   {
     rewrite ^(.*) /${preferredLang}_$preferredRegion$1 last;
   }
-  if (-f "$document_root/$preferredLang$uri")
+  if (-e "$document_root/$preferredLang$uri")
   {
     rewrite ^(.*) /$preferredLang$1 last;
   }
-  if (-f "$document_root/en$uri/$index_page")
-  {
-    rewrite ^(.*) /en$1 last;

[Wladimir Palant, 2015/05/08 21:06:05]

So people will always be redirected to the English version of the page in case
of a directory? That seems wrong. 

In order to avoid duplicating code, why not just check for existance?

if (-e "$document_root/${preferredLang}_$preferredRegion$uri")

This will redirect for both files and directories if they exist. We will only
need the three checks we already have. Note that looking for $index_page
explicitly isn't necessary - if it doesn't exist then it is 404 one way or
another.

[kzar, 2015/05/08 22:01:42]

Shucks, good point. Done.

-  }
-  if (-f "$document_root/en$uri")
+  if (-e "$document_root/en$uri")
   {
     rewrite ^(.*) /en$1 last;
   }
 
   # Redirect server/language root
 
   rewrite ^/$ /$index_page last;
   rewrite ^/(\w\w(_\w\w)?)$ /$1/ permanent;
   rewrite ^/(\w\w(_\w\w)?)/$ /$1/$index_page last;
 }
 
 <% if @multiplexer_locations %>
   <% @multiplexer_locations.each do |location| %>
   location <%= location %>
   {
     fastcgi_pass unix:/tmp/multiplexer-fastcgi.sock;
     include /etc/nginx/fastcgi_params;
   }
   <% end %>
 <% end %>