Add filtersLoaded and filterLoadListener to AdblockPlusApi

adblockplus/Api.jsm

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 38 matching lines @@
     return FilterStorage.subscriptions.some(
       (subscription) => subscription.url == Prefs.subscriptions_exceptionsurl);
   },
   set acceptableAdsEnabled(acceptableAdsEnabled)
   {
     if (acceptableAdsEnabled != AdblockPlusApi.acceptableAdsEnabled)
       UI.toggleAcceptableAds();
   }
 };
 
 FilterNotifier.addListener(function filterListener(action)

[René Jeschke, 2015/03/22 21:01:46]

Oh, and from my side: we do not even really need this listener, anyway. I really
only need 'get filtersLoaded()' above.

[Felix Dahlke, 2015/03/22 21:13:28]

Right, we _can't_ use it there, actually - interaction between Java and JS is
worse than I thought.

In the spirit of not adding unused code, I'll close this review. René can add
the filtersLoaded getter above (as it is there) to his patch.

 {
   if (action != "load")
     return;
 
+  FilterNotifier.removeListener(filterListener);
   if (typeof AdblockPlusApi.filterLoadListener == "function")
     AdblockPlusApi.filterLoadListener();
-  FilterNotifier.removeListener(filterListener);

[Wladimir Palant, 2015/03/22 19:23:34]

Please remove listener as the very first thing - filterLoadListener might
trigger an exception or a recursive call.

[Felix Dahlke, 2015/03/22 20:59:31]

Done.

 });