Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4826294168584192: Issue 2249 - Support UDP sockets in multiplexer.fcgi (Closed)

Created:
March 31, 2015, 7:02 p.m. by mathias
Modified:
April 1, 2015, 8:59 p.m.
CC:
Fred
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2249 for more information..

Patch Set 1 #

Total comments: 6

Patch Set 2 : Issue 2249 - Support UDP sockets in multiplexer.fcgi #

Patch Set 3 : Issue 2249 - Support UDP sockets in multiplexer.fcgi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M multiplexer.fcgi View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10
mathias
March 31, 2015, 7:02 p.m. (2015-03-31 19:02:59 UTC) #1
Wladimir Palant
LGTM
April 1, 2015, 7:08 a.m. (2015-04-01 07:08:05 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode24 multiplexer.fcgi:24: bindAddress = os.environ.get('FCGI_BIND_ADDRESS', None) Nit: .get() defaults to None ...
April 1, 2015, 7:43 a.m. (2015-04-01 07:43:26 UTC) #3
mathias
April 1, 2015, 8 a.m. (2015-04-01 08:00:18 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode26 multiplexer.fcgi:26: match = re.match(r'^(.*?):(\d+)$', bindAddress) On 2015/04/01 07:43:27, Sebastian Noack ...
April 1, 2015, 8:01 a.m. (2015-04-01 08:01:34 UTC) #5
mathias
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode24 multiplexer.fcgi:24: bindAddress = os.environ.get('FCGI_BIND_ADDRESS', None) On 2015/04/01 07:43:27, Sebastian Noack ...
April 1, 2015, 8:03 a.m. (2015-04-01 08:03:11 UTC) #6
Sebastian Noack
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode26 multiplexer.fcgi:26: match = re.match(r'^(.*?):(\d+)$', bindAddress) On 2015/04/01 08:03:11, matze wrote: ...
April 1, 2015, 8:11 a.m. (2015-04-01 08:11:27 UTC) #7
mathias
On 2015/04/01 08:11:27, Sebastian Noack wrote: > http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode26 > multiplexer.fcgi:26: match = re.match(r'^(.*?):(\d+)$', bindAddress) > ...
April 1, 2015, 3:54 p.m. (2015-04-01 15:54:03 UTC) #8
mathias
See https://issues.adblockplus.org/ticket/2249 for more information..
April 1, 2015, 3:55 p.m. (2015-04-01 15:55:58 UTC) #9
Sebastian Noack
April 1, 2015, 6:35 p.m. (2015-04-01 18:35:35 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld