Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(266)

Issue 4826294168584192: Issue 2249 - Support UDP sockets in multiplexer.fcgi (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by mathias
Modified:
4 years, 5 months ago
CC:
Fred
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2249 for more information..

Patch Set 1 #

Total comments: 6

Patch Set 2 : Issue 2249 - Support UDP sockets in multiplexer.fcgi #

Patch Set 3 : Issue 2249 - Support UDP sockets in multiplexer.fcgi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M multiplexer.fcgi View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10
mathias
4 years, 5 months ago (2015-03-31 19:02:59 UTC) #1
Wladimir Palant
LGTM
4 years, 5 months ago (2015-04-01 07:08:05 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode24 multiplexer.fcgi:24: bindAddress = os.environ.get('FCGI_BIND_ADDRESS', None) Nit: .get() defaults to None ...
4 years, 5 months ago (2015-04-01 07:43:26 UTC) #3
mathias
4 years, 5 months ago (2015-04-01 08:00:18 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode26 multiplexer.fcgi:26: match = re.match(r'^(.*?):(\d+)$', bindAddress) On 2015/04/01 07:43:27, Sebastian Noack ...
4 years, 5 months ago (2015-04-01 08:01:34 UTC) #5
mathias
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode24 multiplexer.fcgi:24: bindAddress = os.environ.get('FCGI_BIND_ADDRESS', None) On 2015/04/01 07:43:27, Sebastian Noack ...
4 years, 5 months ago (2015-04-01 08:03:11 UTC) #6
Sebastian Noack
http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi File multiplexer.fcgi (right): http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode26 multiplexer.fcgi:26: match = re.match(r'^(.*?):(\d+)$', bindAddress) On 2015/04/01 08:03:11, matze wrote: ...
4 years, 5 months ago (2015-04-01 08:11:27 UTC) #7
mathias
On 2015/04/01 08:11:27, Sebastian Noack wrote: > http://codereview.adblockplus.org/4826294168584192/diff/5629499534213120/multiplexer.fcgi#newcode26 > multiplexer.fcgi:26: match = re.match(r'^(.*?):(\d+)$', bindAddress) > ...
4 years, 5 months ago (2015-04-01 15:54:03 UTC) #8
mathias
See https://issues.adblockplus.org/ticket/2249 for more information..
4 years, 5 months ago (2015-04-01 15:55:58 UTC) #9
Sebastian Noack
4 years, 5 months ago (2015-04-01 18:35:35 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5