Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 4843664727605248: Issue 2576 - Use urllib instead urllib2 which isn't bundled with runserver.exe (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Sebastian Noack
Modified:
4 years, 9 months ago
Visibility:
Public.

Description

Issue 2576 - Use urllib instead urllib2 which isn't bundled with runserver.exe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M globals/get_browser_versions.py View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Lisa who found the bug, will create an issue for this shortly. The problem is, ...
4 years, 9 months ago (2015-05-22 14:32:29 UTC) #1
Sebastian Noack
I went ahead pushing this fix already, in order to no longer block Lisa. Feel ...
4 years, 9 months ago (2015-05-22 14:48:14 UTC) #2
saroyanm
On 2015/05/22 14:48:14, Sebastian Noack wrote: > I went ahead pushing this fix already, in ...
4 years, 9 months ago (2015-05-22 15:02:05 UTC) #3
Sebastian Noack
On 2015/05/22 15:02:05, saroyanm wrote: > LGTM, can you please just give me idea why ...
4 years, 9 months ago (2015-05-22 15:09:30 UTC) #4
Wladimir Palant
4 years, 9 months ago (2015-05-23 07:30:05 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5