Issue 1451 - Redirect Android devbuild update requests for versions that crash when detecting an up…

modules/downloadserver/files/site.conf

 keepalive_timeout 0;
 root /var/www/downloads;
 
 location /.hg
 {
   internal;
 }
 
 # This redirect is necessary since we accidentally set the wrong
 # update URL in ABP for Android 1.2. It can be removed once we're
 # not seeing anyone requesting this file anymore.
 # Note that this intentionally promotes devbuilds to release builds.
 # Since newer versions should use the new devbuild and release
 # build update URLs requested by libadblockplus, leaving this
 # redirect around won't really hurt.
 location /devbuilds/adblockplusandroid/updates.xml
 {
   rewrite ^ https://adblockplus.org/androidupdates.xml?$query_string redirect;
 }
 
 location /devbuilds
 {
+  # This is necessary since ABP for Android revisions 323 to 337 crash when
+  # detecting an update. Fortunately, we repeated the revision in addonVersion
+  # in these versions for some reason, so we can use that pattern to detect
+  # them.
+  if ($query_string ~ "addonVersion=1\.2\.1\.3\d\d\.3\d\d")

[Wladimir Palant, 2014/09/29 11:36:01]

Please check $arg_addonVersion here.

[Felix Dahlke, 2014/09/29 11:49:15]

Done. Also anchored the expression properly as discussed.

+  {
+    return 200 '{}';
+  }
   alias /var/www/devbuilds;
 }