Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

Issue 4858514686083072: Don't dispatch a "load" event for blocked frames on Safari (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 12 months ago by Sebastian Noack
Modified:
5 years, 11 months ago
Visibility:
Public.

Description

For blocked elements on Safari, we manually dispatch an "error" or "load" event, dependent on whether it was a frame or other element. This is required because of cancelling the "beforeload" event doesn't dispatch an "error" event. But apparently this isn't actually needed for frames, because they already receive a "load" event even when they were blocked. But the much larger problem is, that manually dispatching a "load" event, triggers "beforeload" again, leading to an infinite recursion, in this case.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M safari/ext/content.js View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
5 years, 12 months ago (2014-02-25 10:20:29 UTC) #1
Felix Dahlke
5 years, 11 months ago (2014-02-27 21:05:29 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5