Fix the approach used in ieFirstRun.js

html/static/js/ieFirstRun.js

Index: html/static/js/ieFirstRun.js
===================================================================
--- a/html/static/js/ieFirstRun.js
+++ b/html/static/js/ieFirstRun.js
@@ -1,50 +1,35 @@
-var AdblockPlus = {
-    require: function(param)
-    {
-        if (param == "prefs")
-        {
-            return {
-                Prefs: 
-                {
-                    documentation_link: ""
-                }
+var AdblockPlus = (function()
+{
+  var scopes = {
+    prefs: {
+      Prefs: { documentation_link: "" }
+    },
+    utils: {
+        Utils: { appLocale: "" }
+    },
+    filterClasses: {
+        Filter: { 
+            fromText: { 
+                matches: function(param) { return true } 
             }
         }
-        if (param == "utils")
-        {
-            return {
-                Utils: 
-                {
-                    appLocale: ""
-                }
-            }
-        }
-        if (param == "filterClasses")
-        {
-            return {
-                Filter: 
-                {
-                    fromText: function(param) 
-                    { 
-                        return {
-                            matches: function(param) {
-                                return true; 
-                            } 
-                        }
-                    } 
-                }
-            }
-        }
-        return {};
+    }    
+  }; 
+
+  var result = {
+    require: function(module) {
+      return scopes[module];
     }
-}
+  };
 
-function initWrappers()
-{
-    AdblockPlus.getMessage = function(section, param)
-    {
-        return window.Settings.GetMessage(section, param);
-    }
-    Prefs.documentation_link = window.Settings.GetDocumentationLink();
-    Utils.appLocale = window.Settings.GetAppLocale();
-}
+  window.addEventListener("load", function()

[Wladimir Palant, 2014/03/31 09:50:29]

This won't work in older IE versions. How about you move the addListener()
function from firstRun.js here? It is best to change it into a polyfill so that
we can simply use the standard window.addEventListener() everywhere:

    if (typeof window.addEventListener != "function")
    {
      window.addEventListener = function(type, handler, capture)
      {
        this.attachEvent("on" + type, handler)
      };
    }

Same for removeListener() of course.

[Eric, 2014/06/25 16:21:06]

And by older, that includes IE 8, unfortunately, and even (evidently)
compatibility view in IE 9.

See
http://stackoverflow.com/questions/6927637/addeventlistener-in-internet-explorer
for more detail.

+  {
+    result.getMessage = function(section, param) {
+            return Settings.GetMessage(section, param);
+        }         
+    scopes.prefs.Prefs.documentation_link = Settings.GetDocumentationLink();
+    scopes.utils.Utils.appLocale = Settings.GetAppLocale();
+  }, false);
+
+  return result;
+})();