Issue 1528 - Implemented backend for general tab of new options page

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 (function(global)
 {
   if (!global.ext)
     global.ext = require("ext_background");
 
   var Prefs = require("prefs").Prefs;
   var Utils = require("utils").Utils;
   var FilterStorage = require("filterStorage").FilterStorage;
   var FilterNotifier = require("filterNotifier").FilterNotifier;
   var defaultMatcher = require("matcher").defaultMatcher;
   
   var filterClasses = require("filterClasses");

[Felix Dahlke, 2015/05/28 20:35:41]

Nit: adblockpluschrome typically uses `with` for this IIRC, nicer IMO. But it's
fine by me as it is.

[Thomas Greiner, 2015/06/08 16:12:43]

"Using with is not recommended, and is forbidden in ECMAScript 5 strict mode.
The recommended alternative is to assign the object whose properties you want to
access to a temporary variable."

see
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Statements/with

Note that the "need for `with`" will be gone as soon as Chrome/Opera/Safari
implement destructuring assignments which will allow us to write:

var {Filter, BlockingFilter} = require("filterClasses");

[Felix Dahlke, 2015/06/09 13:04:47]

Oh, I wasn't aware that with isn't working in strict mode - then never mind of
course.

   var Filter = filterClasses.Filter;
   var BlockingFilter = filterClasses.BlockingFilter;
   var Synchronizer = require("synchronizer").Synchronizer;
 
   var subscriptionClasses = require("subscriptionClasses");
   var Subscription = subscriptionClasses.Subscription;
   var DownloadableSubscription = subscriptionClasses.DownloadableSubscription;
   var SpecialSubscription = subscriptionClasses.SpecialSubscription;
 
   function convertObject(keys, obj)
   {
     var result = {};
     for (var i = 0; i < keys.length; i++)
       result[keys[i]] = obj[keys[i]];
     return result;
   }
 
-  var convertSubscription = convertObject.bind(null, ["disabled", "downloadStatus",

[Felix Dahlke, 2015/05/28 20:35:41]

Nit: We might as well go for 80 columns if we wrap here :P

[Thomas Greiner, 2015/06/08 16:12:43]

Done.

-    "homepage", "lastSuccess", "title", "url"]);
+  var convertSubscription = convertObject.bind(null, ["disabled",
+    "downloadStatus", "homepage", "lastSuccess", "title", "url"]);
   var convertFilter = convertObject.bind(null, ["text"]);
 
   var changeListeners = null;
   var messageTypes = {
     "app": "app.listen",
     "filter": "filters.listen",
     "subscription": "subscriptions.listen"
   };
 
   function onFilterChange(action)
@@ skipping 111 matching lines @@
           delete listenerFilters.app;
         break;
       case "app.open":
         if (message.what == "options")
           ext.showOptions();
         break;
       case "filters.add":
         var filter = Filter.fromText(message.text);
         FilterStorage.addFilter(filter);
         break;
       case "filters.blocked":

[Felix Dahlke, 2015/05/28 20:35:41]

Nit: `filters.blocking` maybe?

[Thomas Greiner, 2015/06/08 16:12:43]

This part was added by Wladimir and would require firstRun.js to be adapted
accordingly. I just moved it to have the cases be sorted alphabetically. :)

[Felix Dahlke, 2015/06/09 13:04:47]

Na, let's leave it alone then, not really worth changing existing code over.

         var filter = defaultMatcher.matchesAny(message.url, message.requestType,
           message.docDomain, message.thirdParty);
         callback(filter instanceof BlockingFilter);
         break;
       case "filters.get":
         var subscription = Subscription.fromURL(message.subscriptionUrl);
         if (!subscription)
         {
           callback([]);
           break;
@@ skipping 73 matching lines @@
           subscription.title = message.title;
           subscription.homepage = message.homepage;
           FilterStorage.addSubscription(subscription);
           if (!subscription.lastDownload)
             Synchronizer.execute(subscription);
         }
         break;
     }
   });
 })(this);