Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(111)

Issue 4875867805188096: issue #660 - HTTP cache api v2 fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by saroyanm
Modified:
5 years, 7 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is related to current ticket: https://issues.adblockplus.org/ticket/660#comment:13

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/content/ui/sidebar.js View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4
saroyanm
Wladimir can you please have a look.
5 years, 7 months ago (2014-07-04 09:00:17 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4875867805188096/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (left): http://codereview.adblockplus.org/4875867805188096/diff/5629499534213120/chrome/content/ui/sidebar.js#oldcode324 chrome/content/ui/sidebar.js:324: onCacheEntryCheck: function (entry, appCache) Please don't remove the parameters ...
5 years, 7 months ago (2014-07-04 18:09:00 UTC) #2
saroyanm
New patch uploaded. http://codereview.adblockplus.org/4875867805188096/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (left): http://codereview.adblockplus.org/4875867805188096/diff/5629499534213120/chrome/content/ui/sidebar.js#oldcode324 chrome/content/ui/sidebar.js:324: onCacheEntryCheck: function (entry, appCache) On 2014/07/04 ...
5 years, 7 months ago (2014-07-04 19:32:12 UTC) #3
Wladimir Palant
5 years, 7 months ago (2014-07-05 06:17:51 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5