Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 4879490828206080: Issue 2438 - Update buildtools dependency to revision 97e212af6e8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Felix Dahlke
Modified:
4 years, 9 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2438 - Update buildtools dependency to revision 97e212af6e8

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use hg mv for prefs.js->prefs.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -43 lines) Patch
M defaults/prefs.json View 1 1 chunk +41 lines, -39 lines 0 comments Download
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
4 years, 9 months ago (2015-05-04 19:07:57 UTC) #1
Felix Dahlke
I did some smoke testing here, and ran all the unit tests. Everything seems fine ...
4 years, 9 months ago (2015-05-04 19:15:36 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/4879490828206080/diff/5629499534213120/defaults/prefs.json File defaults/prefs.json (right): http://codereview.adblockplus.org/4879490828206080/diff/5629499534213120/defaults/prefs.json#newcode2 defaults/prefs.json:2: "defaults": { Please don't remove the old file and ...
4 years, 9 months ago (2015-05-04 19:28:09 UTC) #3
Felix Dahlke
Forgot that again :) New patch set is up.
4 years, 9 months ago (2015-05-04 19:31:52 UTC) #4
Wladimir Palant
4 years, 9 months ago (2015-05-04 19:38:01 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5