Fix the platform preprocessor defines

Looks like we are actually using defines with the underscore in the code. In resource compiler this actually causes an error, when a 64-bit build is running without the _WIN64 defined.

[Felix Dahlke, 2014-07-24 07:01:10]

LGTM, although I'm not a reviewer :P

[sergei, 2014-07-24 10:14:09]

Could we just remove it? These macros should be already defined by the compiler,
we don't have to do it manually.
http://msdn.microsoft.com/en-us/library/b0084kay%28v=vs.110%29.aspx

In addition I cannot reproduce the problem described in the description. Could
you provide more details about it, like which file, what causes the error, what
is the error?

[sergei, 2014-07-24 10:15:33]

The link turned broken, the second attempt
http://msdn.microsoft.com/en-us/library/b0084kay(v=vs.110).aspx

[Oleksandr, 2014-07-24 10:18:42]

Try deleting all your build files and then try building a 64-bit build. Resource
compile will try to use TYPELIB "../../build/ia32/AdblockPlus.tlb" instead of a
64-bit version, and that is unavailable in that case.


On 2014/07/24 10:14:09, sergei wrote:
> Could we just remove it? These macros should be already defined by the
compiler,
> we don't have to do it manually.
> http://msdn.microsoft.com/en-us/library/b0084kay%2528v=vs.110%2529.aspx
> 
> In addition I cannot reproduce the problem described in the description. Could
> you provide more details about it, like which file, what causes the error,
what
> is the error?

[Oleksandr, 2014-07-24 10:22:26]

Also, maybe removing it isn't such a good idea since the C++ compiler might
define it itself, but resource compiler apparently does not.


On 2014/07/24 10:18:42, Oleksandr wrote:
> Try deleting all your build files and then try building a 64-bit build.
Resource
> compile will try to use TYPELIB "../../build/ia32/AdblockPlus.tlb" instead of
a
> 64-bit version, and that is unavailable in that case.
> 
> 
> On 2014/07/24 10:14:09, sergei wrote:
> > Could we just remove it? These macros should be already defined by the
> compiler,
> > we don't have to do it manually.
> > http://msdn.microsoft.com/en-us/library/b0084kay%252528v=vs.110%252529.aspx
> > 
> > In addition I cannot reproduce the problem described in the description.
Could
> > you provide more details about it, like which file, what causes the error,
> what
> > is the error?

[sergei, 2014-07-24 10:29:52]

Thanks,

LGTM

[Eric, 2014-07-24 11:27:30]

On 2014/07/24 10:18:42, Oleksandr wrote:
> Resource
> compile will try to use TYPELIB "../../build/ia32/AdblockPlus.tlb" instead of
a
> 64-bit version, and that is unavailable in that case.

We could simplify all this by removing the type library completely. It's not
used by IE to bind the BHO, which means that it's not used at all. The typelib
declaration is, as I recall, an artifact of having used a wizard to set up the
initial project. Otherwise compiling a type library is a harmless tiny bit of
extra build time.

It might be worth an experiment just to remove the typelib declaration and see
if these platform defines are still needed at all.

LGTM, because this is an expedient to fix a build defect with little other
consequence.