sitescripts/notifications/README.md - Issue 4883267715072000: Issue 2276 - Handle groups in notification.json requests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/notifications/README.md

Issue 4883267715072000: Issue 2276 - Handle groups in notification.json requests (Closed)

Patch Set: Address comments Created April 23, 2015, 10:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 notifications

	2 =============

	3

	4 Backend for Adblock Plus notifications. It provides the following URLs:

	5

	6 * /notification.json - Return notifications to show

	7
	kzar 2015/06/03 11:09:50 Description / example of the file format would be Description / example of the file format would be cool here IMHO. Something like the description of https://issues.adblockplus.org/ticket/2162 Felix Dahlke 2015/06/12 11:02:40 Good point, but would you be OK with doing this in Show quoted text On 2015/06/03 11:09:50, kzar wrote: > Description / example of the file format would be cool here IMHO. Something like > the description of https://issues.adblockplus.org/ticket/2162 Good point, but would you be OK with doing this in a follow-up? We surely should properly specify/document the notification format, but I feel doing that properly is a bit out of scope here. I'll file an issue if you agree. Sebastian Noack 2015/06/12 11:15:09 Well, if adding a README.md here isn't out of scop Show quoted text On 2015/06/12 11:02:40, Felix H. Dahlke wrote: > On 2015/06/03 11:09:50, kzar wrote: > > Description / example of the file format would be cool here IMHO. Something > like > > the description of https://issues.adblockplus.org/ticket/2162 > > Good point, but would you be OK with doing this in a follow-up? We surely should > properly specify/document the notification format, but I feel doing that > properly is a bit out of scope here. I'll file an issue if you agree. Well, if adding a README.md here isn't out of scope, documenting it properly shouldn't be either. But up to you. Felix Dahlke 2015/06/12 12:12:52 There are two things we need to document: 1. The n Show quoted text On 2015/06/12 11:15:09, Sebastian Noack wrote: > On 2015/06/12 11:02:40, Felix H. Dahlke wrote: > > On 2015/06/03 11:09:50, kzar wrote: > > > Description / example of the file format would be cool here IMHO. Something > > like > > > the description of https://issues.adblockplus.org/ticket/2162 > > > > Good point, but would you be OK with doing this in a follow-up? We surely > should > > properly specify/document the notification format, but I feel doing that > > properly is a bit out of scope here. I'll file an issue if you agree. > > Well, if adding a README.md here isn't out of scope, documenting it properly > shouldn't be either. But up to you. There are two things we need to document: 1. The notification.json format 2. The format of the notification files in the notifications repository The latter wouldn't be out of scope here since we're changing the format slightly, but the former IMHO is (we're not even changing the notification.json format here), and IMO it's a prerequisite for the latter to make sense. Here's the follow-up: https://issues.adblockplus.org/ticket/2676 kzar 2015/06/15 15:17:37 Fair enough, follow up issue sounds OK to me. Show quoted text On 2015/06/12 12:12:52, Felix Dahlke wrote: > On 2015/06/12 11:15:09, Sebastian Noack wrote: > > On 2015/06/12 11:02:40, Felix H. Dahlke wrote: > > > On 2015/06/03 11:09:50, kzar wrote: > > > > Description / example of the file format would be cool here IMHO. > Something > > > like > > > > the description of https://issues.adblockplus.org/ticket/2162 > > > > > > Good point, but would you be OK with doing this in a follow-up? We surely > > should > > > properly specify/document the notification format, but I feel doing that > > > properly is a bit out of scope here. I'll file an issue if you agree. > > > > Well, if adding a README.md here isn't out of scope, documenting it properly > > shouldn't be either. But up to you. > > There are two things we need to document: > 1. The notification.json format > 2. The format of the notification files in the notifications repository > > The latter wouldn't be out of scope here since we're changing the format > slightly, but the former IMHO is (we're not even changing the notification.json > format here), and IMO it's a prerequisite for the latter to make sense. > > Here's the follow-up: https://issues.adblockplus.org/ticket/2676 Fair enough, follow up issue sounds OK to me.
	8 Required packages

	9 -----------------

	10

	11 * [mock](https://pypi.python.org/pypi/mock) (Only for the tests)

OLD	NEW

« no previous file with comments | « no previous file | sitescripts/notifications/test/__init__.py » ('j') | sitescripts/notifications/web/notification.py » ('J')