chrome/content/ui/subscriptionSelection.js - Issue 4884233277407232: Issue 2257 - Replaced non-standard function expressions with ES6 arrow functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/subscriptionSelection.js

Issue 4884233277407232: Issue 2257 - Replaced non-standard function expressions with ES6 arrow functions (Closed)

Patch Set: Rebased Created May 6, 2015, 10:46 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/ui/subscriptionSelection.js

===================================================================

--- a/chrome/content/ui/subscriptionSelection.js

+++ b/chrome/content/ui/subscriptionSelection.js

@@ -217,7 +217,7 @@

let link = document.createElement("label");

link.className = "text-link";

link.setAttribute("tooltiptext", mainSubscriptionURL);

- link.addEventListener("click", function() UI.loadInBrowser(mainSubscriptionURL), false);

+ link.addEventListener("click", () => UI.loadInBrowser(mainSubscriptionURL), false);

link.textContent = mainSubscriptionTitle;

messageElement.appendChild(link);

messageElement.appendChild(document.createTextNode(afterLink));

@@ -304,5 +304,5 @@

function hasSubscription(url)

{

- return FilterStorage.subscriptions.some(function(subscription) subscription instanceof DownloadableSubscription && subscription.url == url);

+ return FilterStorage.subscriptions.some(subscription => subscription instanceof DownloadableSubscription && subscription.url == url);

}

« no previous file with comments | « chrome/content/ui/sidebar.js ('k') | no next file » | no next file with comments »