chrome/content/ui/sendReport.js - Issue 4884233277407232: Issue 2257 - Replaced non-standard function expressions with ES6 arrow functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/sendReport.js

Issue 4884233277407232: Issue 2257 - Replaced non-standard function expressions with ES6 arrow functions (Closed)

Patch Set: 2nd argument to Utils.runAsync isn't necessary with arrow functions Created April 1, 2015, 5:47 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/ui/sendReport.js

===================================================================

--- a/chrome/content/ui/sendReport.js

+++ b/chrome/content/ui/sendReport.js

@@ -263,7 +263,7 @@

let hitCount = wndStats.filters[f];

appendElement(filters, "filter", {

text: filter.text,

- subscriptions: filter.subscriptions.filter(subscriptionsDataSource.subscriptionFilter).map(function(s) s.url).join(" "),

+ subscriptions: filter.subscriptions.filter(subscriptionsDataSource.subscriptionFilter).map(s => s.url).join(" "),

hitCount: hitCount

});

this.origFilters.push(filter);

@@ -296,7 +296,7 @@

let subscriptionXML = appendElement(subscriptions, "subscription", {

id: subscription.url,

- disabledFilters: subscription.filters.filter(function(filter) filter instanceof ActiveFilter && filter.disabled).length

+ disabledFilters: subscription.filters.filter(filter => filter instanceof ActiveFilter && filter.disabled).length

});

if (subscription.version)

subscriptionXML.setAttribute("version", subscription.version);

@@ -818,7 +818,7 @@

let filtersRemoved = false;

let requests = requestsDataSource.origRequests;

for (let i = 0; i < requests.length; i++)

- if (requests[i].filter && !requests[i].filter.subscriptions.filter(function(s) !s.disabled).length)

+ if (requests[i].filter && !requests[i].filter.subscriptions.filter(s => !s.disabled).length)

filtersRemoved = true;

if (filtersRemoved)

@@ -970,7 +970,7 @@

continue;

this.numAppliedFilters++;

- if (filter.subscriptions.some(function(subscription) subscription instanceof SpecialSubscription))

+ if (filter.subscriptions.some(subscription => subscription instanceof SpecialSubscription))

this.ownFilters.push(filter);

}