Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(292)

Issue 4895499043733504: Issue 510 - [Typed objects] Don`t hardcode script load order in unit tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by Wladimir Palant
Modified:
4 years, 7 months ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 510 - [Typed objects] Don`t hardcode script load order in unit tests

Patch Set 1 #

Total comments: 15

Patch Set 2 : Addressed comments #

Total comments: 5

Patch Set 3 : Reverted to original get_scripts implementation #

Patch Set 4 : Added comment #

Total comments: 2

Patch Set 5 : Using generators to produce responses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -50 lines) Patch
M run_tests.py View 1 2 3 4 1 chunk +53 lines, -22 lines 0 comments Download
M test/common.js View 1 1 chunk +7 lines, -3 lines 0 comments Download
M test/index.html View 1 chunk +35 lines, -25 lines 0 comments Download

Messages

Total messages: 16
Wladimir Palant
4 years, 8 months ago (2015-01-10 00:13:57 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/.hgsubstate File .hgsubstate (right): http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/.hgsubstate#newcode1 .hgsubstate:1: d357001ed1e487cd8854d91370d71bd66c885ef6 jshydra This dependency update is unrelated, I extracted ...
4 years, 8 months ago (2015-01-10 09:06:19 UTC) #2
Felix Dahlke
Looks pretty good. Considering that we're still hard coding script load order in libadblockplus (and ...
4 years, 7 months ago (2015-02-03 06:21:16 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/test/index.html File test/index.html (right): http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/test/index.html#newcode25 test/index.html:25: evalScript = function(source) Missed this before: Why are evalScript ...
4 years, 7 months ago (2015-02-03 06:30:23 UTC) #4
Felix Dahlke
http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/test/index.html File test/index.html (right): http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/test/index.html#newcode25 test/index.html:25: evalScript = function(source) On 2015/02/03 06:30:24, Felix H. Dahlke ...
4 years, 7 months ago (2015-02-03 06:39:44 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/run_tests.py#newcode22 run_tests.py:22: import io On 2015/02/03 06:21:16, Felix H. Dahlke wrote: ...
4 years, 7 months ago (2015-02-03 09:21:10 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5629499534213120/run_tests.py#newcode22 run_tests.py:22: import io On 2015/02/03 09:21:10, Sebastian Noack wrote: > ...
4 years, 7 months ago (2015-02-03 16:26:04 UTC) #7
Felix Dahlke
http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py#newcode33 run_tests.py:33: path = os.path.join(dir, file) posixpath.join?
4 years, 7 months ago (2015-02-04 03:58:51 UTC) #8
Felix Dahlke
http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py#newcode25 run_tests.py:25: import flask While we're nit picking :) PEP-8: "You ...
4 years, 7 months ago (2015-02-04 04:02:34 UTC) #9
Wladimir Palant
http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py#newcode33 run_tests.py:33: path = os.path.join(dir, file) On 2015/02/04 03:58:51, Felix H. ...
4 years, 7 months ago (2015-02-04 15:37:14 UTC) #10
Felix Dahlke
LGTM, one naming suggestion. http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py#newcode33 run_tests.py:33: path = os.path.join(dir, file) On ...
4 years, 7 months ago (2015-02-04 18:20:25 UTC) #11
Wladimir Palant
http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5657382461898752/run_tests.py#newcode33 run_tests.py:33: path = os.path.join(dir, file) On 2015/02/04 18:20:25, Felix H. ...
4 years, 7 months ago (2015-02-04 20:46:14 UTC) #12
Felix Dahlke
LGTM
4 years, 7 months ago (2015-02-05 03:39:41 UTC) #13
Sebastian Noack
http://codereview.adblockplus.org/4895499043733504/diff/5681717746597888/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5681717746597888/run_tests.py#newcode65 run_tests.py:65: data = "" Instead concatenating the whole string here, ...
4 years, 7 months ago (2015-02-05 11:32:20 UTC) #14
Wladimir Palant
http://codereview.adblockplus.org/4895499043733504/diff/5681717746597888/run_tests.py File run_tests.py (right): http://codereview.adblockplus.org/4895499043733504/diff/5681717746597888/run_tests.py#newcode65 run_tests.py:65: data = "" On 2015/02/05 11:32:21, Sebastian Noack wrote: ...
4 years, 7 months ago (2015-02-05 14:51:26 UTC) #15
Sebastian Noack
4 years, 7 months ago (2015-02-05 14:56:43 UTC) #16
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5