Noissue - Remove dead code

Noissue - Remove dead code

Remove BuildVariant.h and PluginClient.h. Move their (very few) definitions
into the (just as few) places they were used. Adjust #include directives as
needed. In addition, remove a number of unnecessary #include directives
throughout the plugin.

Remove DLL entry point functions 'OnInstall' and 'OnUpdate'. Remove function
'InitPlugin' that each of them called.

Remove suppression of warning 4996 from PluginStdAfx.h; the compiler does not
emit this warning on our code any longer. Move declaration of '_Module' out
of PluginStdAfx.h and into PluginClass.cpp, which was the only file that
required it.

Move 'UnescapeUrl' out of PluginClientBase.* and into PluginUtil.*.

[Eric, 2015-03-17 14:38:09]

Small changes overall, but lots of files touched since headers are altered.

[Oleksandr, 2015-03-19 04:39:32]

Looks good overall. Since we are touching a lot of files, I have checked the
include directives and specified which can be removed. Seems like a good
patchset for that.

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/adbl...
File adblockplus.gyp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/adbl...
adblockplus.gyp:44: 'src/shared/IE_version.cpp',
How about including Version.h here as well?

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/AdblockPlusDomTraverser.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/AdblockPlusDomTraverser.cpp:21: #include "PluginClientBase.h"
PluginClientBase.h can be removed here

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/Plugin.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/Plugin.cpp:30: #include "PluginWbPassThrough.h"
I think this can be removed

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginClass.cpp:36: #include <thread>
thread, PluginUserSettings.h, sddl.h, PluginMutex.h, PluginFilter.h can be
removed

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginFilter.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginFilter.cpp:21: #include "PluginSettings.h"
Below: PluginMutex.h, PluginSettings.h, PluginSystem.h, PluginClass.h, mlang.h,
CriticlSection.h all can be removed here. 

PluginSettings.h is included twice.

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginMutex.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginMutex.cpp:22: #include "sddl.h"
This can be removed as well

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginSettings.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginSettings.cpp:28: #include <memory>
Wbemidl.h, time.h, PluginFiter.h, memory.h all can be removed

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginTabBase.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginTabBase.cpp:27: #include <dispex.h>
PluginUtil.h, dispex.h, PluginClass.h can be removed

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginUserSettings.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginUserSettings.cpp:21: #include <algorithm>
Can be removed

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginUtil.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginUtil.cpp:21: #include <algorithm>
algorithm, stdexcept, vector, shlwapi.h, PluginSettings.h can all be removed

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginWbPassThrough.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginWbPassThrough.cpp:27: #include "wtypes.h"
wtypes.h,  PluginSystem.h, PluginFilter.h can be removed

[Eric, 2015-03-20 09:09:45]

New patch set 2 removes more needless #include directives, plus some more dead
code as a bonus.

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/adbl...
File adblockplus.gyp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/adbl...
adblockplus.gyp:44: 'src/shared/IE_version.cpp',
On 2015/03/19 04:39:32, Oleksandr wrote:
> How about including Version.h here as well?

I'll add all the header files, as we did with the plugin code some time back.

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginClass.cpp:36: #include <thread>
On 2015/03/19 04:39:32, Oleksandr wrote:
> thread, PluginUserSettings.h, sddl.h, PluginMutex.h, PluginFilter.h can be
> removed

I removed all but <thread>. I left that one in because we have an explicit
instantiation of it in this file at present.

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
File src/plugin/PluginSettings.cpp (right):

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginSettings.cpp:34: #include <knownfolders.h>
Not only all those, but this one too.

http://codereview.adblockplus.org/4899473029332992/diff/5629499534213120/src/...
src/plugin/PluginSettings.cpp:44: class TSettings
And I also noticed this class isn't used anywhere, either. Bonus!

[sergei, 2015-03-30 10:25:12]

LGTM

[Oleksandr, 2015-05-26 23:09:04]

LGTM