src/plugin/PluginClientBase.h - Issue 4899473029332992: Noissue - Remove dead code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/plugin/PluginClientBase.h

Issue 4899473029332992: Noissue - Remove dead code (Closed)

Patch Set: Created March 17, 2015, 2:35 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2015 Eyeo GmbH	3 * Copyright (C) 2006-2015 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 private:	62 private:

63 static std::vector<CPluginError> s_pluginErrors;	63 static std::vector<CPluginError> s_pluginErrors;

64 static CComAutoCriticalSection s_criticalSectionQueue;	64 static CComAutoCriticalSection s_criticalSectionQueue;

65	65

66 public:	66 public:

67 static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const std::string& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwT hreadId=0);	67 static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const std::string& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwT hreadId=0);

68 static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, cons t std::string& errorDescription);	68 static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, cons t std::string& errorDescription);

69 static bool PopFirstPluginError(CPluginError& pluginError);	69 static bool PopFirstPluginError(CPluginError& pluginError);

70 };	70 };

71	71

72 /**

73 * Wrapper around Microsoft API 'UrlUnescape'

74 *

75 * This function has modify-in-place semantics.

76 * This behavior matches that of the legacy version of this function declared ab ove.

77 * At present, callers of this function have no code to handle error conditions that might arise here.

78 * Because there's no error handling, therefore, this masks failures in UrlUnesc ape.

79 */

80 void UnescapeUrl(std::wstring& url);

81

82 #endif // _PLUGIN_CLIENT_BASE_H_	72 #endif // _PLUGIN_CLIENT_BASE_H_

OLD	NEW

« src/plugin/PluginClass.cpp ('K') | « src/plugin/PluginClient.h ('k') | src/plugin/PluginClientBase.cpp » ('j') | src/plugin/PluginFilter.cpp » ('J')