Noissue - Remove dead code

src/plugin/PluginSettings.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginSettings.h"
-#include "PluginClient.h"
+#include "AdblockPlusClient.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginMutex.h"
 #include "../shared/Utils.h"
 #include <memory>

[Oleksandr, 2015/03/19 04:39:32]

Wbemidl.h, time.h, PluginFiter.h, memory.h all can be removed

 
 
 // IE functions
 #pragma comment(lib, "iepmapi.lib")
 
 #include <knownfolders.h>

[Eric, 2015/03/20 09:09:45]

Not only all those, but this one too.

 
 namespace
 {
   std::wstring CreateDomainWhitelistingFilter(const CString& domain)
   {
     return L"@@||" + ToWstring(domain) + L"^$document";
   }
 }
 
 class TSettings

[Eric, 2015/03/20 09:09:45]

And I also noticed this class isn't used anywhere, either. Bonus!

 {
   DWORD processorId;
 
   char sPluginId[44];
 };
 
 class CPluginSettingsWhitelistLock : public CPluginMutex
 {
 public:
   CPluginSettingsWhitelistLock() : CPluginMutex(L"SettingsFileWhitelist", PLUGIN_ERROR_MUTEX_SETTINGS_FILE_WHITELIST) {}
@@ skipping 227 matching lines @@
 
 CString CPluginSettings::GetAppLocale()
 {
   return ToCString(GetBrowserLanguage());
 }
 
 CString CPluginSettings::GetDocumentationLink()
 {
   return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
 }