Delta Between Two Patch Sets: adblockplus.gyp
Issue 4899473029332992:
Noissue - Remove dead code (Closed)
Left Patch Set:
Created March 17, 2015, 2:35 p.m.
Right Patch Set: remove more #include directives
Created March 20, 2015, 9:05 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
src/plugin/AdblockPlus.def » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 { | 1 { |
| 2 'includes': ['defaults.gypi'], | 2 'includes': ['defaults.gypi'], |
| 3 | 3 |
| 4 'variables': { | 4 'variables': { |
| 5 'build_type%': 'devbuild', | 5 'build_type%': 'devbuild', |
| 6 'build_version%': '', | 6 'build_version%': '', |
| 7 }, | 7 }, |
| 8 | 8 |
| 9 'target_defaults': { | 9 'target_defaults': { |
| 10 'conditions': [ | 10 'conditions': [ |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 } | 28 } |
| 29 ], | 29 ], |
| 30 ], | 30 ], |
| 31 }, | 31 }, |
| 32 | 32 |
| 33 'targets': [{ | 33 'targets': [{ |
| 34 'target_name': 'shared', | 34 'target_name': 'shared', |
| 35 'type': 'static_library', | 35 'type': 'static_library', |
| 36 'sources': [ | 36 'sources': [ |
| 37 'src/shared/AutoHandle.cpp', | 37 'src/shared/AutoHandle.cpp', |
| 38 'src/shared/AutoHandle.h', | |
| 38 'src/shared/Communication.cpp', | 39 'src/shared/Communication.cpp', |
| 40 'src/shared/Communication.h', | |
| 41 'src/shared/CriticalSection.h', | |
| 39 'src/shared/Dictionary.cpp', | 42 'src/shared/Dictionary.cpp', |
| 43 'src/shared/Dictionary.h', | |
| 40 'src/shared/Utils.cpp', | 44 'src/shared/Utils.cpp', |
| 45 'src/shared/Utils.h', | |
| 46 'src/shared/Version.h', | |
| 41 'src/shared/Registry.h', | 47 'src/shared/Registry.h', |
| 42 'src/shared/Registry.cpp', | 48 'src/shared/Registry.cpp', |
| 43 'src/shared/IE_version.h', | 49 'src/shared/IE_version.h', |
| 44 'src/shared/IE_version.cpp', | 50 'src/shared/IE_version.cpp', |
|
Oleksandr
2015/03/19 04:39:32
How about including Version.h here as well?
Eric
2015/03/20 09:09:45
I'll add all the header files, as we did with the
| |
| 45 ] | 51 ] |
| 46 }, | 52 }, |
| 47 | 53 |
| 48 { | 54 { |
| 49 'target_name': 'AdblockPlusEngine', | 55 'target_name': 'AdblockPlusEngine', |
| 50 'type': 'executable', | 56 'type': 'executable', |
| 51 'dependencies': [ | 57 'dependencies': [ |
| 52 'shared', | 58 'shared', |
| 53 'libadblockplus/libadblockplus.gyp:libadblockplus', | 59 'libadblockplus/libadblockplus.gyp:libadblockplus', |
| 54 ], | 60 ], |
| (...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 294 'Release': { | 300 'Release': { |
| 295 'msvs_settings': { | 301 'msvs_settings': { |
| 296 'VCLinkerTool': { | 302 'VCLinkerTool': { |
| 297 'AdditionalDependencies': ['atls.lib'], | 303 'AdditionalDependencies': ['atls.lib'], |
| 298 }, | 304 }, |
| 299 }, | 305 }, |
| 300 }, | 306 }, |
| 301 }, | 307 }, |
| 302 }] | 308 }] |
| 303 } | 309 } |
| LEFT | RIGHT |
« no previous file
|
src/plugin/AdblockPlus.def » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
