Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/PluginSettings.cpp

Issue 4899473029332992: Noissue - Remove dead code (Closed)
Left Patch Set: Created March 17, 2015, 2:35 p.m.
Right Patch Set: remove more #include directives Created March 20, 2015, 9:05 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/PluginSettings.h ('k') | src/plugin/PluginStdAfx.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include "PluginStdAfx.h" 18 #include "PluginStdAfx.h"
19 19
20 #include <Wbemidl.h>
21 #include <time.h>
22 #include "PluginSettings.h" 20 #include "PluginSettings.h"
23 #include "AdblockPlusClient.h" 21 #include "AdblockPlusClient.h"
24 #include "PluginSystem.h" 22 #include "PluginSystem.h"
25 #include "PluginFilter.h"
26 #include "PluginMutex.h" 23 #include "PluginMutex.h"
27 #include "../shared/Utils.h" 24 #include "../shared/Utils.h"
28 #include <memory>
Oleksandr 2015/03/19 04:39:32 Wbemidl.h, time.h, PluginFiter.h, memory.h all can
29
30
31 // IE functions
32 #pragma comment(lib, "iepmapi.lib")
33
34 #include <knownfolders.h>
Eric 2015/03/20 09:09:45 Not only all those, but this one too.
35 25
36 namespace 26 namespace
37 { 27 {
38 std::wstring CreateDomainWhitelistingFilter(const CString& domain) 28 std::wstring CreateDomainWhitelistingFilter(const CString& domain)
39 { 29 {
40 return L"@@||" + ToWstring(domain) + L"^$document"; 30 return L"@@||" + ToWstring(domain) + L"^$document";
41 } 31 }
42 } 32 }
43
44 class TSettings
Eric 2015/03/20 09:09:45 And I also noticed this class isn't used anywhere,
45 {
46 DWORD processorId;
47
48 char sPluginId[44];
49 };
50 33
51 class CPluginSettingsWhitelistLock : public CPluginMutex 34 class CPluginSettingsWhitelistLock : public CPluginMutex
52 { 35 {
53 public: 36 public:
54 CPluginSettingsWhitelistLock() : CPluginMutex(L"SettingsFileWhitelist", PLUGIN _ERROR_MUTEX_SETTINGS_FILE_WHITELIST) {} 37 CPluginSettingsWhitelistLock() : CPluginMutex(L"SettingsFileWhitelist", PLUGIN _ERROR_MUTEX_SETTINGS_FILE_WHITELIST) {}
55 ~CPluginSettingsWhitelistLock() {} 38 ~CPluginSettingsWhitelistLock() {}
56 }; 39 };
57 40
58 CPluginSettings* CPluginSettings::s_instance = NULL; 41 CPluginSettings* CPluginSettings::s_instance = NULL;
59 CComAutoCriticalSection CPluginSettings::s_criticalSectionLocal; 42 CComAutoCriticalSection CPluginSettings::s_criticalSectionLocal;
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 265
283 CString CPluginSettings::GetAppLocale() 266 CString CPluginSettings::GetAppLocale()
284 { 267 {
285 return ToCString(GetBrowserLanguage()); 268 return ToCString(GetBrowserLanguage());
286 } 269 }
287 270
288 CString CPluginSettings::GetDocumentationLink() 271 CString CPluginSettings::GetDocumentationLink()
289 { 272 {
290 return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str()); 273 return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
291 } 274 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld