Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginUtil.h

Issue 4899473029332992: Noissue - Remove dead code (Closed)
Patch Set: Created March 17, 2015, 2:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginUtil.h
===================================================================
--- a/src/plugin/PluginUtil.h
+++ b/src/plugin/PluginUtil.h
@@ -22,4 +22,15 @@
std::wstring UserSettingsFileUrl();
std::wstring FirstRunPageFileUrl();
std::wstring FileUrl(const std::wstring& url);
-std::wstring GetLocationUrl(IWebBrowser2& browser);
+std::wstring GetLocationUrl(IWebBrowser2& browser);
+
+/**
+ * Wrapper around Microsoft API 'UrlUnescape'
+ *
+ * This function has modify-in-place semantics.
+ * This behavior matches that of the legacy version of this function declared above.
+ * At present, callers of this function have no code to handle error conditions that might arise here.
+ * Because there's no error handling, therefore, this masks failures in UrlUnescape.
+ */
+void UnescapeUrl(std::wstring& url);
+

Powered by Google App Engine
This is Rietveld